https://bugzilla.redhat.com/show_bug.cgi?id=2272140 --- Comment #23 from Carl George 🤠 <carl@xxxxxxxxxx> --- The license string looks good now. version_no_tilde is not a macro you need to define yourself, it's part of rust-srpm-macros and the value is derived from the Version tag. It's useful here because the result is the format of the upstream tag (aside from the epoch- prefix), which should be used directly in the Source0 URL for the tarball instead of the commit. There is also a cosmic_minver macro defined that isn't being used anywhere I can see. --- cosmic-term.spec 2024-10-01 23:00:58.451068682 -0500 +++ cosmic-term.spec.new 2024-10-01 23:03:52.112627495 -0500 @@ -9,9 +9,7 @@ # these macros in order to set the VERGEN_GIT_SHA and VERGEN_GIT_COMMIT_DATE # environment variables in multiple sections of the spec file. %global commit 2e2a2376dfe0c6959e4e7d115f7b7d19405737ad -%global version_no_tilde 1.0.0~alpha.2 %global commitdatestring 2024-09-24 09:25:39 -0600 -%global cosmic_minver 1.0.0~alpha.2 Name: cosmic-term Version: 1.0.0~alpha.2 @@ -22,7 +20,7 @@ URL: https://github.com/pop-os/cosmic-term -Source0: https://github.com/pop-os/cosmic-term/archive/%{commit}/cosmic-term-%{version_no_tilde}.tar.gz +Source0: https://github.com/pop-os/cosmic-term/archive/epoch-%{version_no_tilde}/cosmic-term-%{version_no_tilde}.tar.gz # To create the below sources: # * git clone https://github.com/pop-os/cosmic-term at the specified commit # * cargo vendor > vendor-config-%%{version_no_tilde}.toml @@ -48,7 +46,7 @@ %description %{_description} %prep -%autosetup -n %{crate}-%{commit} -p1 -a1 +%autosetup -n cosmic-term-epoch-%{version_no_tilde} -p1 -a1 %cargo_prep -N # Check if .cargo/config.toml exists if [ -f .cargo/config.toml ]; then -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2272140 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202272140%23c23 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
