https://bugzilla.redhat.com/show_bug.cgi?id=2312837 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- The package is APPROVED, but slightly outdated: please update to 0.13.2 if possible. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is mostly generated with rust2rpm, simplifying the review. There are a number of differences, mostly due to the presence of a C-ABI shared library built with cargo-c. -Version: 0.13.2 +Version: 0.13.0 The latest version is 0.13.2. If there is no major obstacle, please update. +BuildRequires: cargo-c >= 0.9.21 This is needed to build the shared library. -%package -n %{crate} +%package -n gstreamer1-plugin-dav1d Summary: %{summary} -# FIXME: paste output of %%cargo_license_summary here -License: # FIXME +# Apache-2.0 OR MIT +# MIT +# MIT OR Apache-2.0 +# Unlicense OR MIT +License: MIT AND (Apache-2.0 OR MIT) AND (Unlicense OR MIT) # LICENSE.dependencies contains a full license breakdown The subpackage containing the C-ABI library is renamed to comply with the guidelines for naming GStreamer plugins: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_gstreamer_plugins The output of %{cargo_license_summary} is correctly included as a comment, and is correctly translated into a License expression as prescribed in https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_license_tags and consistent with https://docs.fedoraproject.org/en-US/legal/license-field/. -%description -n %{crate} %{_description} +# additionally provide the upstream name +Provides: %{crate} = %{version}-%{release} -%files -n %{crate} +%description -n gstreamer1-plugin-dav1d %{_description} + +%files -n gstreamer1-plugin-dav1d %license LICENSE-APACHE %license LICENSE-MIT %license LICENSE.dependencies +%{_libdir}/gstreamer-1.0/libgstdav1d.so Adding a Provides for the upstream name gst-plugin-dav1d is reasonable: it is unlikely to cause conflicts or confusion, and may help the package be more discoverable. The shared library is correctly added to the %files list. It is correct that it is unversioned because it is a plugin, not a system library, and it is installed in a plugin directory rather than a directory on the system linker search path. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_unversioned_shared_objects +%cargo_cbuild This correctly builds the shared library. -# FIXME: install shared library +%cargo_cinstall +# remove statically linked library +rm -v %{buildroot}/%{_libdir}/gstreamer-1.0/libgstdav1d.a +# remove unnecessary pkgconfig file +rm -v %{buildroot}/%{_libdir}/pkgconfig/gstdav1d.pc This correctly installs the shared library, and removes an unwanted static library. I think that removing the pkgconfig file is reasonable: all other gstreamer1-plugin* packages that ship a pkgconfig file also ship headers in /usr/include/gstreamer-1.0/gst/, which this package does not do. It’s possible I am missing something, but I don’t see any way the pkgconfig file would be useful. There is one interesting rpmlint diagnostic: gstreamer1-plugin-dav1d.x86_64: W: unused-direct-shlib-dependency /usr/lib64/gstreamer-1.0/libgstdav1d.so /lib64/libgio-2.0.so.0 This means that libgio-2.0 is linked, but the plugin does not actually use any symbols from it. In theory, this is slightly wasteful of time and memory, but not a significant problem. In practice, it is even less significant, as any process that loads this gstreamer pluging is overwhelmingly likely to have libgio-2.0 loaded already. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/gst-plugin- dav1d-0.13.0/LICENSE-APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is not a real problem, and is a result of reasonable choices in rust2rpm. ===== MUST items ===== C/C++: [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. It is correct that the .so file is unversioned because it is a plugin, not a system library, and it is installed in a plugin directory rather than a directory on the system linker search path. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_unversioned_shared_objects Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* MIT License", "Apache License (v2.0) or MIT license and/or MIT License". 4 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2312837-rust-gst-plugin- dav1d/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gstreamer1-plugin-dav1d , rust-gst-plugin-dav1d-devel , rust-gst- plugin-dav1d+default-devel , rust-gst-plugin-dav1d+capi-devel , rust- gst-plugin-dav1d+doc-devel , rust-gst-plugin-dav1d+static-devel [?]: Package functions as described. Tests are compiled and run correctly, but zero tests are included. I did not attempt an interactive video playback test. [!]: Latest version is packaged. Version 0.13.0 is packaged, but the latest version is now 0.13.2. Please update if possible. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. Since a dependency is not yet imported, and I did not want to start a COPR, I verified this by local mock builds in qemu-user-static emulation. [x]: %check is present and all tests pass. Tests are compiled and run correctly, but zero tests are included. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gstreamer1-plugin-dav1d-0.13.0-1.fc42.x86_64.rpm rust-gst-plugin-dav1d-devel-0.13.0-1.fc42.noarch.rpm rust-gst-plugin-dav1d+default-devel-0.13.0-1.fc42.noarch.rpm rust-gst-plugin-dav1d+capi-devel-0.13.0-1.fc42.noarch.rpm rust-gst-plugin-dav1d+doc-devel-0.13.0-1.fc42.noarch.rpm rust-gst-plugin-dav1d+static-devel-0.13.0-1.fc42.noarch.rpm rust-gst-plugin-dav1d-debugsource-0.13.0-1.fc42.x86_64.rpm rust-gst-plugin-dav1d-0.13.0-1.fc42.src.rpm ============================================================================================ rpmlint session starts =========================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpzpv4ax4_')] checks: 32, packages: 8 gstreamer1-plugin-dav1d.x86_64: W: no-documentation rust-gst-plugin-dav1d+capi-devel.noarch: W: no-documentation rust-gst-plugin-dav1d+default-devel.noarch: W: no-documentation rust-gst-plugin-dav1d+doc-devel.noarch: W: no-documentation rust-gst-plugin-dav1d+static-devel.noarch: W: no-documentation rust-gst-plugin-dav1d-devel.noarch: W: no-documentation ====================================================== 8 packages and 0 specfiles checked; 0 errors, 6 warnings, 46 filtered, 0 badness; has taken 0.7 s ====================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 7 gstreamer1-plugin-dav1d.x86_64: W: unused-direct-shlib-dependency /usr/lib64/gstreamer-1.0/libgstdav1d.so /lib64/libgio-2.0.so.0 rust-gst-plugin-dav1d+doc-devel.noarch: W: no-documentation rust-gst-plugin-dav1d+capi-devel.noarch: W: no-documentation gstreamer1-plugin-dav1d.x86_64: W: no-documentation rust-gst-plugin-dav1d+static-devel.noarch: W: no-documentation rust-gst-plugin-dav1d+default-devel.noarch: W: no-documentation rust-gst-plugin-dav1d-devel.noarch: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 7 warnings, 40 filtered, 0 badness; has taken 0.5 s Unversioned so-files -------------------- gstreamer1-plugin-dav1d: /usr/lib64/gstreamer-1.0/libgstdav1d.so Source checksums ---------------- https://crates.io/api/v1/crates/gst-plugin-dav1d/0.13.0/download#/gst-plugin-dav1d-0.13.0.crate : CHECKSUM(SHA256) this package : a386d18d3645957c5382e2a7ec77356d219e397991df78951810bd57b10b1b9f CHECKSUM(SHA256) upstream package : a386d18d3645957c5382e2a7ec77356d219e397991df78951810bd57b10b1b9f Requires -------- gstreamer1-plugin-dav1d (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libdav1d.so.7()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgstvideo-1.0.so.0()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) rust-gst-plugin-dav1d-devel (rpmlib, GLIBC filtered): (crate(dav1d/default) >= 0.10.3 with crate(dav1d/default) < 0.11.0~) (crate(gst-plugin-version-helper/default) >= 0.8.0 with crate(gst-plugin-version-helper/default) < 0.9.0~) (crate(gstreamer-base/default) >= 0.23.0 with crate(gstreamer-base/default) < 0.24.0~) (crate(gstreamer-base/v1_18) >= 0.23.0 with crate(gstreamer-base/v1_18) < 0.24.0~) (crate(gstreamer-video/default) >= 0.23.0 with crate(gstreamer-video/default) < 0.24.0~) (crate(gstreamer-video/v1_18) >= 0.23.0 with crate(gstreamer-video/v1_18) < 0.24.0~) (crate(gstreamer/default) >= 0.23.0 with crate(gstreamer/default) < 0.24.0~) (crate(gstreamer/v1_18) >= 0.23.0 with crate(gstreamer/v1_18) < 0.24.0~) (crate(num_cpus/default) >= 1.0.0 with crate(num_cpus/default) < 2.0.0~) (crate(once_cell/default) >= 1.0.0 with crate(once_cell/default) < 2.0.0~) cargo rust rust-gst-plugin-dav1d+default-devel (rpmlib, GLIBC filtered): cargo crate(gst-plugin-dav1d) rust-gst-plugin-dav1d+capi-devel (rpmlib, GLIBC filtered): cargo crate(gst-plugin-dav1d) rust-gst-plugin-dav1d+doc-devel (rpmlib, GLIBC filtered): (crate(gstreamer/v1_18) >= 0.23.0 with crate(gstreamer/v1_18) < 0.24.0~) cargo crate(gst-plugin-dav1d) rust-gst-plugin-dav1d+static-devel (rpmlib, GLIBC filtered): cargo crate(gst-plugin-dav1d) rust-gst-plugin-dav1d-debugsource (rpmlib, GLIBC filtered): Provides -------- gstreamer1-plugin-dav1d: gst-plugin-dav1d gstreamer1(decoder-video/x-av1)()(64bit) gstreamer1(element-dav1ddec)()(64bit) gstreamer1-plugin-dav1d gstreamer1-plugin-dav1d(x86-64) libgstdav1d.so()(64bit) rust-gst-plugin-dav1d-devel: crate(gst-plugin-dav1d) rust-gst-plugin-dav1d-devel rust-gst-plugin-dav1d+default-devel: crate(gst-plugin-dav1d/default) rust-gst-plugin-dav1d+default-devel rust-gst-plugin-dav1d+capi-devel: crate(gst-plugin-dav1d/capi) rust-gst-plugin-dav1d+capi-devel rust-gst-plugin-dav1d+doc-devel: crate(gst-plugin-dav1d/doc) rust-gst-plugin-dav1d+doc-devel rust-gst-plugin-dav1d+static-devel: crate(gst-plugin-dav1d/static) rust-gst-plugin-dav1d+static-devel rust-gst-plugin-dav1d-debugsource: rust-gst-plugin-dav1d-debugsource rust-gst-plugin-dav1d-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -L gst-plugin-dav1d-deps/ -b 2312837 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Python, Java, PHP, SugarActivity, Ocaml, Haskell, R, fonts, C/C++, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Built with local dependencies: /home/ben/fedora/review/gst-plugin-dav1d-deps/rust-byte-slice-cast+default-devel-1.2.2-1.fc42.noarch.rpm /home/ben/fedora/review/gst-plugin-dav1d-deps/rust-byte-slice-cast-devel-1.2.2-1.fc42.noarch.rpm /home/ben/fedora/review/gst-plugin-dav1d-deps/rust-byte-slice-cast+std-devel-1.2.2-1.fc42.noarch.rpm /home/ben/fedora/review/gst-plugin-dav1d-deps/rust-av-data+default-devel-0.4.3-1.fc42.noarch.rpm /home/ben/fedora/review/gst-plugin-dav1d-deps/rust-av-data-devel-0.4.3-1.fc42.noarch.rpm /home/ben/fedora/review/gst-plugin-dav1d-deps/rust-dav1d+default-devel-0.10.3-1.fc42.noarch.rpm /home/ben/fedora/review/gst-plugin-dav1d-deps/rust-dav1d-devel-0.10.3-1.fc42.noarch.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2312837 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202312837%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
