[Bug 2315381] Review Request: glycin - Sandboxed image rendering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2315381



--- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> ---
(In reply to Neal Gompa from comment #3)
> Package was generated with rust2rpm, simplifying the review.
> 
> ✅ package contains only permissible content
> ✅ package builds and installs without errors on rawhide (in a side-tag)
> ✅ test suite is run and all unit tests pass
> ✅ latest version of the crate is packaged
> ✅ license matches upstream specification and is acceptable for Fedora
> ✅ license file is included with %license in %files
> ✅ package complies with Rust Packaging Guidelines
> 
> Package APPROVED.


Well, actually, this isn't done with rust2rpm, but the review checks are
largely the same anyway. :)

> ===
> 
> Recommended post-import rust-sig tasks:
> 
> - set up package on release-monitoring.org:
>   project: $crate
>   homepage: https://crates.io/crates/$crate
>   backend: crates.io
>   version scheme: semantic
>   version filter: alpha;beta;rc;pre
>   distro: Fedora
>   Package: rust-$crate
> 
> - add @rust-sig with "commit" access as package co-maintainer
>   (should happen automatically)
> 
> - set bugzilla assignee overrides to @rust-sig (optional)
> 
> - track package in koschei for all built branches
>   (should happen automatically once rust-sig is co-maintainer)

Most of this doesn't apply, but adding gnome-sig and rust-sig as co-maintainers
would be good too.

(This is what I get for using a formula and pressing enter too quickly before
finishing modifying the response...)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2315381

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202315381%23c4

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux