https://bugzilla.redhat.com/show_bug.cgi?id=2276414 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|AutomationTriaged | --- Comment #6 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok BuildRequires FIX: Add build-requires coreutils it is needed for %{_fixperms} perl(strict) - lib/Call/Context.pm:78 perl(warnings) - lib/Call/Context.pm:79 If you don't want to add it to EPEL 7, please consider fixing these 'TODO' items: TODO: Add "NO_PACKLIST=1 NO_PERLLOCAL=1" to 'perl Makefile.PL' If you use option NO_PACKLIST=1, please add version constrain to ExtUtils::MakeMaker >= 6.76 Remove "find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;". TODO: Use %{make_install} instead of "make pure_install". TODO: Remove "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';'" It's not needed. $ rpm -qp --requires perl-Call-Context-0.05-1.fc42.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl-libs 1 perl(strict) 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-Call-Context-0.05-1.fc42.noarch.rpm | sort | uniq -c 1 perl(Call::Context) = 0.05 1 perl-Call-Context = 0.05-1.fc42 1 perl(Call::Context::X) Binary provides are Ok. Rpmlint is ok TODO: The package does not contain directory %{perl_vendorarch}/auto/, you can remove '%exclude %dir %{perl_vendorarch}/auto/' TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: NOT Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2276414 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276414%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
