https://bugzilla.redhat.com/show_bug.cgi?id=2303960 --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Few initial observations 1) Why to specify arch list in this line? ExclusiveArch: x86_64 aarch64 ppc64le See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_support 2) Why this package need below line? %global debug_package %{nil} See more https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/ 3) Why many patches needed for this package? Try to contact upstream and see if these patches can be merged upstream. We want to see no patches needed or distro specific patches needed for any Fedora package. See https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/ 4) make command should follow https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make 5) %check section should only execute testsuite not build there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2303960 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202303960%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
