https://bugzilla.redhat.com/show_bug.cgi?id=2296174 --- Comment #20 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Dominik 'Rathann' Mierzejewski from comment #19) > (In reply to wojnilowicz from comment #10) > > (In reply to Dominik 'Rathann' Mierzejewski from comment #9) > [...] > > > I've just read on Matrix in #devel:fedoraproject.org that: [...] with Qt, > > > you can often get by without using xvfb-run or a successor by setting > > > QT_QPA_PLATFORM=offscreen in the environment. > > > > Done. Thanks for your support in this. Does it look good now? > > > > Spec URL: https://wojnilowicz.fedorapeople.org/python-aw-qt.spec > > SRPM URL: https://wojnilowicz.fedorapeople.org/python-aw-qt-0^20240903.43864b2-1.fc39.src.rpm > > It does! The help2man issue is fixed and the tests are executed. > > Not sure if the stderr output of the integration tests indicates anything > was tested, but they exit with 0, so you tell me. ;) > ========== stderr ========== > 2024-09-24 16:38:40 [INFO ]: Started aw-qt... (aw_qt.main:53) > 2024-09-24 16:38:40 [WARNING]: Found matching file but was not executable: > /builddir/build/BUILD/python-aw-qt-0_20240903.43864b2-build/aw-qt- > 43864b2f7ec3b71d5b181eafb47b4ded6c197b8f/aw-qt.spec (aw_qt.manager:64) > 2024-09-24 16:38:40 [INFO ]: Found 0 bundled modules (aw_qt.manager:85) > 2024-09-24 16:38:40 [INFO ]: Found 0 system modules (aw_qt.manager:119) > 2024-09-24 16:38:40 [INFO ]: Creating trayicon... (aw_qt.trayicon:208) > > ============================ > > APPROVED. The author prints the stderr output at https://github.com/ActivityWatch/aw-qt/blob/d20a9419c5d94479a633c611c68138886a3ff135/tests/integration_tests.py#L42. It is printed also outside of rpmbuild, so I think it's harmless. I believe it might be intended and comes from the line at https://github.com/ActivityWatch/aw-core/blob/3b83ab542406349b3d5e601318289b77d23d906f/aw_core/log.py#L27 Anyhow, thanks for the review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2296174 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202296174%23c20 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
