Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evolution-rss - Evolution RSS Reader Plugin https://bugzilla.redhat.com/show_bug.cgi?id=430070 ------- Additional Comments From cooly@xxxxxxxxxxx 2008-01-30 14:42 EST ------- Thanks for your reply, > cc-ing Dan. This won't build with libsoup 2.4 (rawhide) > http://koji.fedoraproject.org/koji/taskinfo?taskID=381907 At this time libsoup-2.2 is required by configure PKG_CHECK_MODULES(EVOLUTION_RSS_EPLUGIN, [libgnome-2.0 >= $LIBGNOME_REQUIRED dnl libgnomeui-2.0 >= $LIBGNOMEUI_REQUIRED dnl gtk+-2.0 >= $LIBGTK_REQUIRED dnl libsoup-2.2 >= $LIBSOUP_REQUIRED dnl Building against 2.4 crashes the plugin and somehow related to soup_message_get_header. > From quick glance at your spec file: > * Would you explain why this package should have > "Requies: firefox"? Actually that is firefox-devel > Requires: firefox-devel Application requires gtkmozembed that is actually packed in firefox-devel. Initially I thought I could provide two different packages gtkmozembed and nogtkmozembed, but finally this could get confusing so I rather pack it using gtkmozembed and the user can choose the renderer. That's why firefox-devel is required. > * Perhaps "Requires: dbus, dbus-glib" is redundant (and > should be removed). rpmbuild checks the dependency for libraries > and adds the dependency to rebuilt binary rpms, which > should pull dbus, dbus-glib automatically dropped > * "BuildRequires: gettext" is redundant if "BuildRequires: > gettext-devel" is really needed. dropped gettext-devel as it is not really required keep gettext for build requires > * "BuildRequires: gcc-c++" is redundant (see the section > "Exceptions" of > http://fedoraproject.org/wiki/Packaging/Guidelines ) dropped > * "BuildRequires: dbus" is redundant. dbus-glib-devel > requires dbus. dropped > * Please try to use %configure macro updated > * GConf scriptlet is not right. Please refer to > the section "GConf" of > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets updated > * %_prefix/bin must be replaced with %_bindir. corrected > By the way, now it seems your spec/srpm link seem 404 (not found)? there are some local problems there with the connection, sorry for the inconvenience I've also updated spec and srpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review