https://bugzilla.redhat.com/show_bug.cgi?id=2314104 --- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review! (In reply to Fabio Valentini from comment #5) > Have you submitted the fix for the mix-of-CRLF-and-LF-line-endings to > upstream? > Those kind of issues are usually unintentional and caused by careless moving > between Windows and Linux without setting the necessary git attributes. Hmm, I could. I usually do offer a PR when there are just a couple of files and it looks like an accident, but several projects I looked at under https://github.com/rkyv/ or https://github.com/djkoloski/ (at least munge_macro, munge, rancor, and rkyv) had a significant number of CRLF-terminated files in the released crates, so I kind of surmised that upstream just doesn’t consider it a problem. I just submitted https://github.com/djkoloski/munge/pull/5 as a trial balloon. I can open PR’s on other rkyv/djkoloski repos if that one goes well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2314104 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202314104%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
