https://bugzilla.redhat.com/show_bug.cgi?id=2313784 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx --- Comment #13 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Can we remove the bundled jiter crate in %prep to prove we aren’t using it? Something like this should work: %prep %autosetup -p1 -n %{srcname}-%{version} # There is no top-level LICENSE file, but the one from the bundled jiter crate # is the correct license. mv crates/jiter/LICENSE ./ # However, we want to use the system copy of the jiter crate. rm -r crates/jiter # E.g., for 0.5.0, this would allow 0.5.x. tomcli set crates/jiter-python/Cargo.toml str dependencies.jiter.version "%{version}" tomcli set crates/jiter-python/Cargo.toml del dependencies.jiter.path %cargo_prep Also, it’s kind of a convention to put the cargo_license_summary output above the License tag – and it looks like the lines from cargo_license_summary have been incorrectly combined. Something like this should be right: # python-jiter is MIT only, but the rest are rust libraries # based on cargo_license_summary output: # # Apache-2.0 OR MIT # BSD-2-Clause OR Apache-2.0 OR MIT # MIT # MIT OR Apache-2.0 (duplicate) License: %{shrink: (Apache-2.0 OR MIT) AND (BSD-2-Clause OR Apache-2.0 OR MIT) AND MIT } By the way, you are welcome to add me as a co-maintainer on this package once it’s approved, since I have been doing most of the updates to the rust-jiter package and the two are closely linked. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2313784 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313784%23c13 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
