[Bug 2312850] Review Request: rust-async-generic - Write code that can be both async and synchronous without duplicating it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2312850

Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

The spec file is almost exactly as generated by rust2rpm, simplifying the
review. The sole difference is that missing license files in the upstream crate
are correctly handled by offering upstream a PR to fix the problem, then
supplying the missing license files from git as additional sources.

Without context, the differences are:

  +# https://github.com/scouten/async-generic/pull/13
  +Source1:       
https://github.com/scouten/async-generic/raw/async-generic-v%{version}/LICENSE-APACHE
  +Source2:       
https://github.com/scouten/async-generic/raw/async-generic-v%{version}/LICENSE-MIT

  -# FIXME: no license files detected
  +%license %{crate_instdir}/LICENSE-APACHE
  +%license %{crate_instdir}/LICENSE-MIT

  +cp -pav %{SOURCE1} %{SOURCE2} .

Issues:
=======
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/share/cargo/registry/async-
  generic-1.1.1/LICENSE-APACHE
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_duplicate_files

  This is due to reasonable choices in rust2rpm and is not a serious problem.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 6 files have unknown license. Detailed
     output of licensecheck in /home/ben/fedora/review/2312850-rust-async-
     generic/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.

     https://github.com/scouten/async-generic/pull/13

[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     async-generic-devel , rust-async-generic+default-devel
[?]: Package functions as described.

     Tests compile and “pass,” but there are zero tests included in the crate.

[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.

     License texts are necessarily and correctly included as additional
     sources, taken from the upstream VCS repository. Upstream was offered a PR
     to fix missing license texts.

[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.

     (But – there are zero tests!)

[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rust-async-generic-devel-1.1.1-1.fc42.noarch.rpm
          rust-async-generic+default-devel-1.1.1-1.fc42.noarch.rpm
          rust-async-generic-1.1.1-1.fc42.src.rpm
===========================================================================================
rpmlint session starts
===========================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpf5egzmd8')]
checks: 32, packages: 3

rust-async-generic+default-devel.noarch: W: no-documentation
===================================================== 3 packages and 0
specfiles checked; 0 errors, 1 warnings, 12 filtered, 0 badness; has taken 0.2
s ======================================================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

rust-async-generic+default-devel.noarch: W: no-documentation
 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 8 filtered, 0
badness; has taken 0.1 s 



Source checksums
----------------
https://github.com/scouten/async-generic/raw/async-generic-v1.1.1/LICENSE-MIT :
  CHECKSUM(SHA256) this package     :
e2f3f7651bcdcbad5e19f15fb289cb1178375d0e8657b86330bf2f8f959ec631
  CHECKSUM(SHA256) upstream package :
e2f3f7651bcdcbad5e19f15fb289cb1178375d0e8657b86330bf2f8f959ec631
https://github.com/scouten/async-generic/raw/async-generic-v1.1.1/LICENSE-APACHE
:
  CHECKSUM(SHA256) this package     :
661bac26aca538aa717abfcfc824e9393b2ee49797a4b4ef6cc718eb4b6c9e68
  CHECKSUM(SHA256) upstream package :
661bac26aca538aa717abfcfc824e9393b2ee49797a4b4ef6cc718eb4b6c9e68
https://crates.io/api/v1/crates/async-generic/1.1.1/download#/async-generic-1.1.1.crate
:
  CHECKSUM(SHA256) this package     :
80548ada198a0260b9e9d09dfce57919d6c239c3aae2309b3efc1f89096a0e29
  CHECKSUM(SHA256) upstream package :
80548ada198a0260b9e9d09dfce57919d6c239c3aae2309b3efc1f89096a0e29


Requires
--------
rust-async-generic-devel (rpmlib, GLIBC filtered):
    (crate(proc-macro2/default) >= 1.0.0 with crate(proc-macro2/default) <
2.0.0~)
    (crate(quote/default) >= 1.0.0 with crate(quote/default) < 2.0.0~)
    (crate(syn/default) >= 2.0.0 with crate(syn/default) < 3.0.0~)
    (crate(syn/full) >= 2.0.0 with crate(syn/full) < 3.0.0~)
    (crate(syn/visit-mut) >= 2.0.0 with crate(syn/visit-mut) < 3.0.0~)
    cargo
    rust

rust-async-generic+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(async-generic)



Provides
--------
rust-async-generic-devel:
    crate(async-generic)
    rust-async-generic-devel

rust-async-generic+default-devel:
    crate(async-generic/default)
    rust-async-generic+default-devel



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2312850
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: fonts, Ocaml, Java, Python, PHP, Haskell, C/C++, Perl, R,
SugarActivity
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2312850

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202312850%23c3

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux