https://bugzilla.redhat.com/show_bug.cgi?id=2314467 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- The only issue I found was with the accuracy of the patch description comment. The package is APPROVED, but please improve the comment description on import. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated by rust2rpm, simplifying the review. The only changes I noted were the following patch, +# Manually created patch for downstream crate metadata changes +# * drop unused, benchmark-only criterion dev-dependency +# * drop unused optional support for borsh +Patch: ordermap-fix-metadata.diff and the resulting absence of the %{name}+borsh-devel metapackage. However, the description is not quite accurate: there was never a dev-dependency on criterion, and the patch merely patches out the [[bench]] entries. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/ordermap-0.5.3/LICENSE-APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is due to reasonable decisions in rust2rpm, and is not a real problem. - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-ordermap See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names I note that this will be a review for unretirement of https://src.fedoraproject.org/rpms/rust-ordermap under https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_Process/#Unretire_a_Package. - Please update the description of ordermap-fix-metadata.diff to accurately describe what you’re doing with the benchmarks and why, since it doesn’t look like criterion is involved. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License". 33 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2314467-rust- ordermap/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- ordermap-devel , rust-ordermap+default-devel , rust- ordermap+arbitrary-devel , rust-ordermap+quickcheck-devel , rust- ordermap+rayon-devel , rust-ordermap+serde-devel , rust-ordermap+std- devel [x]: Package functions as described. (Tests pass.) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-ordermap-devel-0.5.3-1.fc42.noarch.rpm rust-ordermap+default-devel-0.5.3-1.fc42.noarch.rpm rust-ordermap+arbitrary-devel-0.5.3-1.fc42.noarch.rpm rust-ordermap+quickcheck-devel-0.5.3-1.fc42.noarch.rpm rust-ordermap+rayon-devel-0.5.3-1.fc42.noarch.rpm rust-ordermap+serde-devel-0.5.3-1.fc42.noarch.rpm rust-ordermap+std-devel-0.5.3-1.fc42.noarch.rpm rust-ordermap-0.5.3-1.fc42.src.rpm =========================================================================================== rpmlint session starts =========================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpgpssobrc')] checks: 32, packages: 8 rust-ordermap+arbitrary-devel.noarch: W: no-documentation rust-ordermap+default-devel.noarch: W: no-documentation rust-ordermap+quickcheck-devel.noarch: W: no-documentation rust-ordermap+rayon-devel.noarch: W: no-documentation rust-ordermap+serde-devel.noarch: W: no-documentation rust-ordermap+std-devel.noarch: W: no-documentation ===================================================== 8 packages and 0 specfiles checked; 0 errors, 6 warnings, 37 filtered, 0 badness; has taken 0.4 s ====================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 7 rust-ordermap+serde-devel.noarch: W: no-documentation rust-ordermap+std-devel.noarch: W: no-documentation rust-ordermap+quickcheck-devel.noarch: W: no-documentation rust-ordermap+rayon-devel.noarch: W: no-documentation rust-ordermap+arbitrary-devel.noarch: W: no-documentation rust-ordermap+default-devel.noarch: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 6 warnings, 33 filtered, 0 badness; has taken 0.2 s Source checksums ---------------- https://crates.io/api/v1/crates/ordermap/0.5.3/download#/ordermap-0.5.3.crate : CHECKSUM(SHA256) this package : 31f2bd7b03bf2c767e1bb7b91505dbe022833776e60480275e6f2fb0db0c7503 CHECKSUM(SHA256) upstream package : 31f2bd7b03bf2c767e1bb7b91505dbe022833776e60480275e6f2fb0db0c7503 Requires -------- rust-ordermap-devel (rpmlib, GLIBC filtered): (crate(indexmap) >= 2.5.0 with crate(indexmap) < 3.0.0~) cargo rust rust-ordermap+default-devel (rpmlib, GLIBC filtered): cargo crate(ordermap) crate(ordermap/std) rust-ordermap+arbitrary-devel (rpmlib, GLIBC filtered): (crate(arbitrary) >= 1.0.0 with crate(arbitrary) < 2.0.0~) (crate(indexmap/arbitrary) >= 2.5.0 with crate(indexmap/arbitrary) < 3.0.0~) cargo crate(ordermap) rust-ordermap+quickcheck-devel (rpmlib, GLIBC filtered): (crate(indexmap/quickcheck) >= 2.5.0 with crate(indexmap/quickcheck) < 3.0.0~) (crate(quickcheck) >= 1.0.0 with crate(quickcheck) < 2.0.0~) cargo crate(ordermap) rust-ordermap+rayon-devel (rpmlib, GLIBC filtered): (crate(indexmap/rayon) >= 2.5.0 with crate(indexmap/rayon) < 3.0.0~) (crate(rayon/default) >= 1.5.3 with crate(rayon/default) < 2.0.0~) cargo crate(ordermap) rust-ordermap+serde-devel (rpmlib, GLIBC filtered): (crate(indexmap/serde) >= 2.5.0 with crate(indexmap/serde) < 3.0.0~) (crate(serde) >= 1.0.0 with crate(serde) < 2.0.0~) cargo crate(ordermap) rust-ordermap+std-devel (rpmlib, GLIBC filtered): (crate(indexmap/std) >= 2.5.0 with crate(indexmap/std) < 3.0.0~) cargo crate(ordermap) Provides -------- rust-ordermap-devel: crate(ordermap) rust-ordermap-devel rust-ordermap+default-devel: crate(ordermap/default) rust-ordermap+default-devel rust-ordermap+arbitrary-devel: crate(ordermap/arbitrary) rust-ordermap+arbitrary-devel rust-ordermap+quickcheck-devel: crate(ordermap/quickcheck) rust-ordermap+quickcheck-devel rust-ordermap+rayon-devel: crate(ordermap/rayon) rust-ordermap+rayon-devel rust-ordermap+serde-devel: crate(ordermap/serde) rust-ordermap+serde-devel rust-ordermap+std-devel: crate(ordermap/std) rust-ordermap+std-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2314467 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Perl, fonts, R, Haskell, Ocaml, Java, Python, PHP, C/C++, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2314467 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202314467%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
