[Bug 2309760] Review Request: accel-ppp - High-performance VPN and broadband protocol server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2309760

Neil Hanlon <neil@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #13 from Neil Hanlon <neil@xxxxxxxx> ---
Agreed that this is a difficult one, and probably better to err on the side of
not versioning it. The guidelines[1] state that we "MUST" try and convince
upstream to version the SO, but I believe that may be done in parallel, as this
won't affect anything meaningfully in Fedora if this occurs. Just be mindful in
the future if packages depend on this, and there is an ABI change, branch
packages may require rebuilds.

Thank you, Orion and Cristian for your input!

Notes:

1) In Fedora we can just use `ExcludeArch: %{ix86}` as we i686 artifacts are
not required. For EPEL, instead of:

```
%ifnarch i686
# Do this because we don't have an i686 kernel
BuildRequires:  kernel-modules-extra
%endif
```

For EPEL branches, you can conditionalize on `0%{?rhel}`



---

APPROVED with the above change to drop ix86.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2309760

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202309760%23c13

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux