https://bugzilla.redhat.com/show_bug.cgi?id=2313784 --- Comment #9 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks for the update - looks pretty good already! There's just some minor things left, I think: > # For included rust code > BuildRequires: rust-packaging >= 25 I don't know where you got this from, but it's ... weird. rust-packaging no longer exists, and is only provided for backwards compatibility since version 24. Please replace this BuildRequires "cargo-rpm-macros". Not sure why you'd need version >= 25, or if >= 24 would do. > # Upstream does not provide a license file inside the PyPi package. > Source1: https://github.com/pydantic/jiter/blob/main/LICENSE Hm, the tarball *does* contain a license text, but the directory layout in it is weirdly different from the one in the upstream project. I think in your last version you copied the one from the crates/jiter subdirectory? It's a copy of the one in the root of the project's repository, so it *should* also be applicable to the Python module, and you wouldn't need to include it separately here. > export RUSTFLAGS="%build_rustflags" This is no longer necessary on Fedora >= 40. So if you don't intend to build this package on Fedora 39 (while it's still alive) or EPEL 9, you should be able to drop this. It is set by "%set_build_flags" in Fedora 40+ automatically. > %cargo_license_summary This is nice and all, but you actually need to take the output of that macro and put it into the spec file, and adjust the License tag of the python3-jiter subpackage accordingly. > - python3-pytest7 is deprecated, you must not depend on it. > Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ This looks like a false positive - I only see an unversioned dependency on py3dist(pytest), which should pull in the latest version, and not the v7 compat package? > - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/python-jiter/diff.txt > Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ The URL you provided points at the GitHub HTML view of that file, but not the raw contents. Replacing https://github.com/pydantic/jiter/blob/main/LICENSE with https://github.com/pydantic/jiter/raw/main/LICENSE should resolve this issue. And I would also recommend to replace "main" in that URL with "v0.5.0" to specifically link to the contents of the LICENSE file at the point v0.5.0 was tagged, not the current "HEAD" of the "main" branch. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2313784 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313784%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
