https://bugzilla.redhat.com/show_bug.cgi?id=2309760 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxx --- Comment #9 from Cristian Le <fedora@xxxxxxxxx> --- The build system is rather wonky for this one. - cpack wise, we don't use it at all, so you can ignore tgat variable - minimum cmake version is waaay too old and it *should* be bumped, otherwise it would be skipping some default settings that are assumed when writing a cmake project - check of you want to set any of the `BUILD_PPTP_DRIVER` options - upstream abuses `CMAKE_C_FLAGS` incredibly. Make sure Fedora's flags are being picked up appropriately and not overridden - how did you try to add `set_target_properties`? You can't add it to `accel-pppd` because it's and executable. Something like `crypto` (`internal-crypto` target) can set the versions - we don't want to use the RPATH that they are setting, instead `/etc/ld.so.conf.d/` would work, assuming there are no SONAME/SOVERSION collisions - the sbin install directory should be changed to bin to prepare for thr merger - I believe pcre2 should be preferred instead of pcre. Not sure how compatible the APIs are - there is sooo much more to review in this package, I don't know if rewriting their build system is faster than pointing out each issues (In reply to Orion Poplawski from comment #8) > I doubt that the .so file are development libraries but dlopened() code - > that's why they are installed into %{_libdir}/accel-pppd instead of > %{_libdir}. They do not need versioning. They seem to be configured by accel-ppp.conf so should make sure a good default isstructure. Haven't checked if it has some inheritance structure. This does conflict with the RPATH they are setting -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2309760 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202309760%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
