[Bug 2313784] Review Request: python-jiter - Fast iterable JSON parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2313784



--- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Regarding 1)

%generate_buildrequires
%pyproject_buildrequires
%cargo_generate_buildrequires

In this case, the Python dependency generator runs first because ... it is
first in the script. 🥇
If switching these two around isn't enough, then we'll need to figure out
something else.
I seem to remember having seen this issue in some place before, but I can't
remember details right now.

Regerding 2)

I think replacing this line:

> jiter = { path = "../jiter", features = ["python", "num-bigint"] }

with this one:

> jiter = { version = "0.5.0", features = ["python", "num-bigint"] }

should work to use the jiter sources from the rust-jiter package instead of the
ones bundled here.

Keep in mind that this will likely tie the update cycle of this package with
the one of rust-jiter, since they're published together from
https://github.com/pydantic/jiter/, as far as I can tell.

If you want to keep things independent, building *without* adding a dependency
on rust-jiter might make things more flexible.
In this case, I would recommend taking the patches from rust-jiter to avoid the
codspeed dependency.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2313784

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313784%23c5

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux