https://bugzilla.redhat.com/show_bug.cgi?id=2264719 Miroslav Suchý <msuchy@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(msuchy@xxxxxxxxxx | |) | |needinfo?(msuchy@xxxxxxxxxx | |) | |needinfo?(msuchy@xxxxxxxxxx | |) | --- Comment #15 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- > The upstream release is 400kb, Git snapshot is cca 20MB, git-archive-all is cca 25MB, what is in your src.rpm is 125MB. > That seems to be huge difference. I cannot use neither git snapshot and nor git-archive-all because the upstream build scripts use git operations. And if `.git` directory is missing then the build fails. So I have to include `.git` directory of main repository and submodules. The other option is to completely rework rel-engs scripts of upstream. > As bare minimum there should be repeatable instructions how to obtain the source code. I did. These comments starting on line 11 in https://download.copr.fedorainfracloud.org/results/msuchy/package-review/fedora-rawhide-x86_64/07921582-blesh/blesh.spec > If it is not possible to include the full download URL in the Source0, then it is preferred to have a prepared download script Fair enough. I added the script as Source2. > I would say adding to profile.d and working out of the box is OK. I feel very uncomfortable about it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2264719 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202264719%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
