[Bug 2313221] Review Request: python-inline-snapshot - Golden master/snapshot/approval testing library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2313221



--- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Thank you for the review!

(In reply to Maxwell G from comment #4)

> 1.
> 
>     tomcli get pyproject.toml -F newline-list
> tool.hatch.envs.hatch-test.extra-dependencies | grep -v -e pyright -e mypy
> 
>     (or tomcli-get if you prefer) is the tomcli command to query for the
> test dependencies if you prefer that to manually maintaining version
> constraints. Otherwise, your current approach is fine.

Hmm, that might be a worthwhile change. I tend to resort to listing test
dependencies manually once there is a lot I need to filter out, but here there
are only two things, so unless upstream starts adding a bunch of coverage and
linting tools, it might be worth using the suggested approach.

> 
> 2. Please update to the latest version. See below.

Will do! This will be easy, since the only change was that the tomllib PR I was
carrying as a patch was merged.

(In reply to Maxwell G from comment #5)
> If you don't mind taking a look at
> https://bugzilla.redhat.com/show_bug.cgi?id=2275006, also, that'd be great.

I will take a look at this within the next few days.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2313221

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313221%23c6

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux