https://bugzilla.redhat.com/show_bug.cgi?id=2296174 wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | --- Comment #6 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Dominik 'Rathann' Mierzejewski from comment #4) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > 1. The manpage generated by help2man contains a traceback: > > ModuleNotFoundError: No module named 'aw_qt' > I suggest adding the location of the module installed in buildroot to > PYTHONPATH before calling help2man. Done. > 2. It looks like the module includes tests, but they are not executed. > See tests/integration_tests.py. I see no possibility for it to work. It seems that I need a display (undoable even locally on my PC with rpmbuild) to make this test pass. I added following lines to the spec though: # The following integration test couldn't be run due to the following error # "qt.qpa.xcb: could not connect to display" # %{python3} tests/integration_tests.py --no-modules Is it OK to leave it like that? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2296174 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202296174%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
