Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: synce-kpm - SynCE KDE PDA Manager https://bugzilla.redhat.com/show_bug.cgi?id=430509 ------- Additional Comments From panemade@xxxxxxxxx 2008-01-30 04:46 EST ------- Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM. But NOT for RPM. synce-kpm.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/synceKPM/synce_kpm_main.py 0644 ==> Can you fix this? or its needed? synce-kpm.noarch: E: explicit-lib-dependency libxslt-python ==> Ok + source files match upstream. 89d3f7352ddc7bc64a44353466da802e synce-kpm-0.11.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop file handled correctly. + GUI app. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review