https://bugzilla.redhat.com/show_bug.cgi?id=2313221 Maxwell G <maxwell@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ CC| |maxwell@xxxxxxx --- Comment #4 from Maxwell G <maxwell@xxxxxxx> --- Notes ====== 1. tomcli get pyproject.toml -F newline-list tool.hatch.envs.hatch-test.extra-dependencies | grep -v -e pyright -e mypy (or tomcli-get if you prefer) is the tomcli command to query for the test dependencies if you prefer that to manually maintaining version constraints. Otherwise, your current approach is fine. 2. Please update to the latest version. See below. Maxwell's Python Package Review Template ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The license text is included and marked with %license. NOTE: Included in dist-info - [x] The package builds successfully in mock. - [x] The package is installable (checked by mock --postinstall). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [!] The latest version is packaged or packaging an earlier version is justified. Please update to 0.13.1 on import. Then you can also drop your patch. - [x] The packager considers avoiding confusing `%foo_name` macros. (Not a blocker) - [x] Libraries: The package name has a `python3-` prefix and uses the canonical project name - [x] The pyproject macros are used. - [x] There are no bundled libraries. - [x] The package complies with the Python and general Packaging Guidelines. Package approved, but don't forget to update to the latest version. On import, don't forget to add the package to release-monitoring.org. You can give @python-packagers-sig `commit` if you wish` Thanks! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2313221 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313221%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
