https://bugzilla.redhat.com/show_bug.cgi?id=2312851 --- Comment #12 from Cristian Le <fedora@xxxxxxxxx> --- > - the "BuildRequires: python3-test" is either unnecessary or covered by %generate_buildrequires and can be dropped This part is about supporting `test.support` which is part of python stdlib, so it cannot be picked up by generate_buildrequires since it doesn't have a `python3dist()`. Ah, but indeed it is covered by `jaraco.test`, I was previously trying out to test without `jaraco.test`, must have been a remnant from then. I'll remove it at import. > - the sed command could use a comment (e.g. "# Preserve environment when calling Python from tests so that the tests can pass during RPM build") Fair point, I'll add comments during the import ``` # tests are calling `python3 -m ...` which would need to propagate PYTHONPATH pointing to the installed package ``` Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2312851 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202312851%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
