https://bugzilla.redhat.com/show_bug.cgi?id=2312851 Ondrej Mosnáček <omosnacek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? | |needinfo?(fedora@xxxxxxxxx) Doc Type|--- |If docs needed, set a value CC| |omosnacek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |omosnacek@xxxxxxxxx --- Comment #2 from Ondrej Mosnáček <omosnacek@xxxxxxxxx> --- Review notes: [!]: %check is present and all tests pass. -> it is actually possible to make the test work by patching it as follows: sed -i "s/\\('-m', 'backports.tarfile',\\)/\\1 __cleanenv=False,/g" tests/test_tarfile.py The rest looks good to me. Will paste the full review checklist once the above is addressed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2312851 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202312851%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
