https://bugzilla.redhat.com/show_bug.cgi?id=2313401 Troy Dawson <tdawson@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(package-review@li |fedora-review+ |sts.fedoraproject.org) | Status|ASSIGNED |MODIFIED --- Comment #4 from Troy Dawson <tdawson@xxxxxxxxxx> --- APPROVED Note: I looked at the licenses files and gave a comment in my review. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file BlackOnLightYellow.colorscheme.license is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text -- Note on this issue incase others look at this. There are several *.license files in the color-schemes and kb-layouts directories. These files are not really licenses, but xml files stating which licenses the schemes/layouts have. The real license files are in their proper license place. Thus I approved this review request. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2313401 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313401%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue