https://bugzilla.redhat.com/show_bug.cgi?id=2313276 --- Comment #2 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Matthias, thank you for the package :-) Overall the package looks really good. Only a few issues. > Copr build: > https://copr.fedorainfracloud.org/coprs/build/8030838 > (failed) This package depends on python-pulp-glue from RHBZ 2313205. It was already accepted and successfully built in Fedora. Please ignore the failure > # BuildRequires: pyproject-rpm-macros A leftover comment in the specfile > Recommends: python3-pygments python3-click-shell python3-secretstorage This is perfectly fine, but from personal experience, I'd recommend writing it like this: Recommends: python3-pygments Recommends: python3-click-shell Recommends: python3-secretstorage It will be more readable once the list of dependencies starts growing, diffs will be more understandable and so on. > Issues: > ======= > - Package must not depend on deprecated() packages. > Note: python3-toml is deprecated, you must not depend on it. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/deprecating-packages/ Rpmlint complains about this ^^. Looking at the python-toml package here https://src.fedoraproject.org/rpms/python-toml it says "This package is deprecated, use tomllib from the Python standard library or tomli/tomli-w". Is that something you can do? > pulp-cli.noarch: W: no-manual-page-for-binary pulp Just a warning ... if you have a manpage for the tool, please install it through the package. If you don't please ignore. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2313276 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313276%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
