https://bugzilla.redhat.com/show_bug.cgi?id=2313339 --- Comment #6 from Thomas Fitzsimmons <fitzsim@xxxxxxxxxx> --- Here are a bunch of my initial thoughts: - I don't know if the EPL applies to six lines of configuration. It seems weird to put any license on this. - "To ensure this, repository files must initially include the enabled=0 (or equivalent) setting, and the user must explicitly enable third-party repositories to install from them. FESCo may grant an exception to waive this requirement." I think you should apply to FESCo to have the Temurin repository enabled by default; the repos contain entirely Free Software (correct me if I am wrong here), and current users are used to "dnf install java-1.8.0-openjdk". - As I mentioned in email, I would like to see Temurin use the "java-1.8.0-temurin" naming scheme. Are aliases (somewhere, not sure where) an option, such that "dnf install java-1.8.0-openjdk" maps to Temurin's equivalent 1.8.0 package? - I don't typically like whitespace-aligning the fields in the header, because the alignment hard to maintain; either things drift out of alignment as fields are added or removed, or whitespace-only changes to the entire header are necessary to maintain alignment, which clutter history. - Can you please use capitals where appropriate in the Summary line? - The Summary should be more descriptive. For example: $ rpm -qi fedora-repos-38-1.noarch|tail -n2 Description : Fedora package repository files for yum and dnf along with gpg public keys. - Can you please clarify this comment? I think it is too vague: # except tool owns also fedora-third-party/conf.d/ Requires: fedora-third-party and it's a nit pick, but can you make comments start with a capital and take the form of a full sentence? - I would probably just inline these and eliminate the extra two lines to set variables. %global repodir yum.repos.d %global thirdparty lib/fedora-third-party/conf.d Either that or go all the way: %global thirdparty %{_prefix}/lib/fedora-third-party/conf.d/ %global repodir %{_sysconfdir}/yum.repos.d but... just inline them. - What does lib/fedora-third-party/conf.d do? It is not referenced in the upstream instructions. (I am only looking at the spec file so far, have not attempted reverse-engineering behaviours based on the contents of the SRPM) - The description needs a lot of work. I don't like having to click the URL to see the package's entire contents to know what it does. Can you try rephrasing it? - Can you get rid of all the extra newlines? It is too hard to maintain double-spacing consistently, so only ever use one blank line (maximum) to separate sections. - Is there a Fedora packaging style guide for how to format RPM changelog entries? Should they start with a capital, for example? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2313339 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313339%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
