https://bugzilla.redhat.com/show_bug.cgi?id=2301577 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #13 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thanks! I reviewed the spec-file diff, and confirmed that the requested changes are present and correct. I also checked that there were no new rpmlint messages or fedora-review findings. The package is APPROVED. --- ../srpm-unpacked/python-universal-pathlib.spec 2024-09-13 20:00:00.000000000 -0400 +++ 2301577-python-universal-pathlib/srpm-unpacked/python-universal-pathlib.spec 2024-09-15 20:00:00.000000000 -0400 @@ -2,7 +2,7 @@ ## (rpmautospec version 0.7.2) ## RPMAUTOSPEC: autorelease, autochangelog %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: - release_number = 1; + release_number = 3; base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); print(release_number + base_release_number - 1); }%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} @@ -19,7 +19,10 @@ Release: %{autorelease} Summary: Pathlib api extended to use fsspec backends -License: MIT +# The entire source is MIT, except that upath/_compat.py contains code from +# CPython (see https://github.com/python/cpython/blob/v3.12.2/Lib/pathlib.py), +# which is Python-2.0.1. +License: MIT AND Python-2.0.1 URL: %forgeurl %forgemeta @@ -34,6 +37,14 @@ BuildRequires: python3-devel BuildRequires: %{py3_dist pytest} +# Parts of upath/_compat.py are copied from CPython 3.12. Since the relevant +# work began on 2024-02-20 in +# https://github.com/fsspec/universal_pathlib/pull/200 and was merged in +# https://github.com/fsspec/universal_pathlib/pull/200 on 2024-03-03, we +# ascribe the code to the latest 3.12 release at the time. +Provides: bundled(python3-libs) = 3.12.2 + + %description -n python3-universal-pathlib %_description %package doc @@ -52,16 +63,13 @@ -e '/"pylint.*"/d' \ -e '/"mypy.*"/d' \ -e '/"pytest-mypy-plugins.*"/d' \ + -e '/"pytest-sugar.*"/d' \ pyproject.toml deps_to_remove=("s3fs" "adlfs" "moto\[s3,server\]") echo "Removing deps that are unavailable in Fedora: ${deps_to_remove[*]}" (IFS="|" ; sed -Ei "/(${deps_to_remove[*]})/d" pyproject.toml) -# Comment out to remove /usr/bin/env shebangs -# Can use something similar to correct/remove /usr/bin/python shebangs also -# find . -type f -name "*.py" -exec sed -i '/^#![ ]*\/usr\/bin\/env.*$/ d' {} 2>/dev/null ';' - %generate_buildrequires export SETUPTOOLS_SCM_PRETEND_VERSION=%{version} %pyproject_buildrequires -x dev -x tests @@ -87,7 +95,7 @@ # LICENSE/COPYING are included in the dist-info, so we do not need to # explicitly list them again %files -n python3-universal-pathlib -f %{pyproject_files} -%doc README.md +%doc README.md CHANGELOG.md %files doc %doc notebooks @@ -95,6 +103,12 @@ %changelog ## START: Generated by rpmautospec +* Mon Sep 16 2024 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@xxxxxxxxx> - 0.2.5-3 +- feat: update license for bundled bits + +* Mon Sep 16 2024 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@xxxxxxxxx> - 0.2.5-2 +- feat: add changelog, remove pytest-sugar + * Sat Sep 14 2024 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur@xxxxxxxxx> - 0.2.5-1 - feat: ready for review -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2301577 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202301577%23c13 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
