[Bug 2310847] Review Request: perl-Auth-Yubikey_WebClient - Authenticating the Yubikey against the Yubico Web API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2310847

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |jplesnik@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |jplesnik@xxxxxxxxxx



--- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok
FIX: Add build-require 'coreutils' it is needed for %{_fixperms}

$ rpm -qp --requires perl-Auth-Yubikey_WebClient-4.02-1.fc42.noarch.rpm | sort
| uniq -c | grep -v rpmlib
      1 perl(Digest::HMAC_SHA1)
      1 perl-libs
      1 perl(LWP::UserAgent)
      1 perl(MIME::Base64)
      1 perl(strict)
      1 perl(URI::Escape)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Auth-Yubikey_WebClient-4.02-1.fc42.noarch.rpm | sort
| uniq -c
      1 perl(Auth::Yubikey_WebClient) = 4.02
      1 perl-Auth-Yubikey_WebClient = 4.02-1.fc42
Binary provides are Ok.

$ rpmlint ./perl-Auth-Yubikey_WebClient*
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
perl-Auth-Yubikey_WebClient.spec:33: W: macro-in-comment %{version}
perl-Auth-Yubikey_WebClient.spec:33: W: macro-in-comment %{version}
 2 packages and 1 specfiles checked; 0 errors, 2 warnings, 8 filtered, 0
badness; has taken 0.3 s
Rpmlint 
FIX: the warning 'macro-in-comment %{version}'

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items.

Resolution:
Approved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2310847

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202310847%23c2

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux