https://bugzilla.redhat.com/show_bug.cgi?id=2276412 --- Comment #7 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok Description is ok URL and Source0 are ok License FIX: License should be 'GPL-1.0-or-later OR Artistic-1.0-Perl' All tests passed FIX: Please set AUTHOR_TESTING or remove BRs perl(Test::Pod) and unset AUTHOR_TESTING BuildRequires FIX: Add build-requires coreutils it is needed for %{_fixperms} perl(B) - lib/TOML/Tiny/Writer.pm:8 perl(charnames) - lib/TOML/Tiny/Tokenizer.pm:7 perl(constant) - lib/TOML/Tiny/Writer.pm:13 perl(DateTime) - t/writer.t:4 perl(feature) - t/toml-test/valid/array/* perl(Math::BigFloat) - lib/TOML/Tiny/Parser.pm:13 perl(parent) - lib/TOML/Tiny.pm:12 perl(strict) - lib/TOML/Tiny.pm:4 perl(utf8) - lib/TOML/Tiny/Parser.pm:4 perl(warnings) - lib/TOML/Tiny.pm:5 FIX: Use 'perl(:VERSION) >= 5.18' instead of 'perl-interpreter >= 5.18' because the package has an epoch. NOTE: You can use utility 'tangerine' for getting list of almost all dependencies Because you don't want to add it to EPEL 7, please consider fixing these 'TODO' items: TODO: Add "NO_PACKLIST=1 NO_PERLLOCAL=1" to 'perl Makefile.PL' If you use option NO_PACKLIST=1, please add version constrain to ExtUtils::MakeMaker >= 6.76 Remove "find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;". TODO: Use %{make_install} instead of "make pure_install". TODO: Remove "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';'" It's not needed. $ rpm -qp --requires perl-TOML-Tiny-0.18-1.fc42.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(B) 1 perl(Carp) 1 perl(charnames) 1 perl(constant) 1 perl(Data::Dumper) 1 perl(Encode) 1 perl(Exporter) 1 perl-libs 1 perl(Math::BigFloat) 1 perl(Math::BigInt) 1 perl(parent) 1 perl(strict) 1 perl(TOML::Tiny::Grammar) 1 perl(TOML::Tiny::Parser) 1 perl(TOML::Tiny::Tokenizer) 1 perl(TOML::Tiny::Util) 1 perl(TOML::Tiny::Writer) 1 perl(utf8) 1 perl(:VERSION) >= 5.18.0 1 perl(warnings) Binary requires are Ok. TODO: Add optional run-require 'perl(Types::Serialiser)' lib/TOML/Tiny/Parser.pm:22 $ rpm -qp --provides perl-TOML-Tiny-0.18-1.fc42.noarch.rpm | sort | uniq -c 1 perl(TOML::Tiny) = 0.18 1 perl-TOML-Tiny = 0.18-1.fc42 1 perl(TOML::Tiny::Grammar) = 0.18 1 perl(TOML::Tiny::Parser) = 0.18 1 perl(TOML::Tiny::Tokenizer) = 0.18 1 perl(TOML::Tiny::Util) = 0.18 1 perl(TOML::Tiny::Writer) = 0.18 Binary provides are Ok. $ rpmlint ./perl-TOML-Tiny* ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-TOML-Tiny.src: E: unknown-key 98927a7e perl-TOML-Tiny.noarch: E: spelling-error ('serializer', 'Summary(en_US) serializer -> serialize, serializes, serialized') perl-TOML-Tiny.src: E: spelling-error ('serializer', 'Summary(en_US) serializer -> serialize, serializes, serialized') perl-TOML-Tiny.noarch: W: invalid-license Artistic-1.0 perl-TOML-Tiny.src: W: invalid-license Artistic-1.0 2 packages and 1 specfiles checked; 3 errors, 2 warnings, 7 filtered, 3 badness; has taken 0.4 s Rpmlint is ok TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. NOTE: There are base Perl Packaging Guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: NOT Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2276412 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276412%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
