https://bugzilla.redhat.com/show_bug.cgi?id=2309760 --- Comment #6 from Neil Hanlon <neil@xxxxxxxx> --- Notes/Questions: 1) license SPDX appears to be (GPL-2.0-Only OR GPL-2.0-Or-Later OR MIT) 2) pcre package is deprecated, will this build with pcre2? may need to pull in https://github.com/accel-ppp/accel-ppp/pull/185 3) when a package has a system unit associated, we need to handle this in the pre/post sections of the rpm install; see https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets 4) unversioned shared libraries must be handled -- see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries -- if upstream cannot version them, we can maintain versioning on it downstream. the unversioned .so files can be in a devel subpackage, if you want 5) you can use globs for non-library files, so instead of listing all the entries in `%{_datadir}/accel-ppp/radius/`, you could just add `%{_datadir}/accel-ppp/radius/dictionary*`. as long as it's not a shared directory or is shared object libraries, globbing is OK. 6) need to own directories -- Note: Directories without known owners: /usr/share/accel-ppp, /usr/lib64/accel-ppp, /usr/share/accel-ppp/l2tp, /usr/share/accel-ppp/radius 7) can any tests be run in %check? lastly, regarding ># We need Centos9 for modern Fedora versions alongside EPEL 9 > %cmake -DCMAKE_BUILD_TYPE=Release -DCPACK_TYPE=Centos9 This is probably OK, but we should probably ask upstream if adding a Fedora config would be possible, as that config will diverge from either Fedora or CentOS/EPEL at some point in the future. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2309760 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202309760%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
