https://bugzilla.redhat.com/show_bug.cgi?id=2308448 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #24 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thank you for the update, package looks good to me now. There's just two minor issues pointed out by rpmlint that need to be clarified: > rublk.x86_64: W: unused-direct-shlib-dependency /usr/bin/rublk /lib64/libm.so.6 Not sure where this comes from? > rublk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/rublk This one looks slightly concerning - is rublk supposed to be a SUID binary? Those have been getting phased out since Fedora 15 (!): https://fedoraproject.org/wiki/Features/RemoveSETUID *If* the rublk executable is supposed to be a SUID binary, then it needs to be marked as such in packaging with the correct attribute, otherwise the SUID bit will not be set on the file. And independently, it looks like the setuid code isn't handled correctly upstream, according to the rpmlint error. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2308448 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202308448%23c24 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
