Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: filesystem https://bugzilla.redhat.com/show_bug.cgi?id=225752 limb@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |limb@xxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From limb@xxxxxxxxxxxx 2008-01-29 14:05 EST ------- rpmlint on srpm: filesystem.src: E: non-utf8-spec-file /tmp/filesystem-2.4.11-1.fc8.src.rpm.12176/filesystem.spec The character encoding of the spec file is not UTF-8. Convert it for example using iconv(1). Fix. filesystem.src:78: E: hardcoded-library-path in /lib A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. Special case, ok. filesystem.src: W: no-%build-section The spec file does not contain a %build section. Even if some packages don't directly need it, section markers may be overridden in rpm's configuration to provide additional "under the hood" functionality, such as injection of automatic -debuginfo subpackages. Add the section, even if empty. Fix. filesystem.src: W: mixed-use-of-spaces-and-tabs (spaces: line 31, tab: line 28) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Cosmetic, but easy to fix. filesystem.src: E: tag-not-utf8 %changelog The character encoding of the value of this tag is not UTF-8. Fix. filesystem.src: W: no-url-tag The URL tag is missing. Fix. If we're upstream, get a spot on hosted for this. Also, since the license is listed as Public Domain, we either need something in the one file of source there is, the lang-exceptions file, or have something in %doc stating the license. rpmlint on rpms: filesystem.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. Is there anything to include here? filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man4x A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/include A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/games A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: non-standard-dir-perm /tmp 01777 A standard directory should have permission set to 0755. If you get this message, it means that you have wrong directory permissions in some dirs included in your package. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/src A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: non-standard-dir-perm /var/lock 0775 A standard directory should have permission set to 0755. If you get this message, it means that you have wrong directory permissions in some dirs included in your package. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man2x A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/bin A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/info A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man7x A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: non-standard-dir-perm /proc 0555 A standard directory should have permission set to 0755. If you get this message, it means that you have wrong directory permissions in some dirs included in your package. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/sbin A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/applications A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-mnt /mnt/cdrom A file in the package is located in /mnt. It's not permitted for packages to install files in this directory. filesystem.i386: E: non-standard-dir-perm /var/spool/mail 0775 A standard directory should have permission set to 0755. If you get this message, it means that you have wrong directory permissions in some dirs included in your package. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/lib A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man3x A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man9x A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man6x A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/libexec A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/mann A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: non-standard-dir-perm /root 0750 A standard directory should have permission set to 0755. If you get this message, it means that you have wrong directory permissions in some dirs included in your package. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man4 A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man5 A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man6 A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man7 A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man1 A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man2 A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man8 A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man9 A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: non-standard-dir-perm /var/tmp 01777 A standard directory should have permission set to 0755. If you get this message, it means that you have wrong directory permissions in some dirs included in your package. filesystem.i386: E: non-standard-dir-perm /usr/share/empty 0555 A standard directory should have permission set to 0755. If you get this message, it means that you have wrong directory permissions in some dirs included in your package. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man5x A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/etc A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man8x A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man1x A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-usr-local /usr/local/share/man/man3 A file in the package is located in /usr/local. It's not permitted for packages to install files in this directory. filesystem.i386: E: dir-or-file-in-mnt /mnt/floppy A file in the package is located in /mnt. It's not permitted for packages to install files in this directory. These are all fine. Special case. filesystem.i386: E: tag-not-utf8 %changelog The character encoding of the value of this tag is not UTF-8. Will be fixed in SRPM, above. filesystem.i386: W: no-url-tag The URL tag is missing. See above. filesystem.i386: E: no-binary The package should be of the noarch architecture because it doesn't contain any binaries. Should this be made noarch, or would that break the _lib arch conditional? Duplicate files: warning: File listed twice: /usr/share/locale/ca_ES@valencian warning: File listed twice: /usr/share/locale/ca_ES@valencian/LC_MESSAGES Otherwise, looks good, no other blockers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review