https://bugzilla.redhat.com/show_bug.cgi?id=2308448 --- Comment #17 from Ming Lei <minlei@xxxxxxxxxx> --- Hi Fabio, Thanks for the review! (In reply to Fabio Valentini from comment #16) > I'm getting errors when trying to download the files with "fedora-review" ... > > ERROR: 'Error <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate > verify failed: unable to get local issuer certificate (_ssl.c:1000)> > downloading > https://people.redhat.com/minlei/fedpkg/rublk/rust-rublk-0.2.1-1.fc40.src. > rpm' > > Is people.redhat.com having issues with its HTTPS certificate? I don't know, maybe it is one transient issue, can you check it again? I just try to download the src.rpm from one fresh VM and my android mobile phone, not see such issue. > > ======================================== > > You have (BSD-2-Clause OR Apache-2.0 OR MIT) in your License tag. > When doing a local build, I don't get any dependency in the package's > dependency tree with that license string. > > You will need to check *for every new version* that the summary and license > tag are still accurate. > The output of the %cargo_license_summary macro during the build of the > current version is > > # 0BSD OR MIT OR Apache-2.0 > # Apache-2.0 OR BSL-1.0 > # Apache-2.0 OR MIT > # Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT > # BSD-3-Clause > # GPL-2.0-or-later > # MIT > # MIT OR Apache-2.0 > # MIT OR Zlib OR Apache-2.0 > # MPL-2.0+ > # Unlicense OR MIT > > (which is what you should also paste into the spec file above the > subpackage's License tag, as instructed by the spec generated by rust2rpm) > > ======================================== > > Your package also statically links the regex-syntax crate, which has (for > our standards in Fedora / Red Hat) incomplete license information. It > bundles code that's derived from Unicode data, resulting in code covered by > the Unicode-DFS-2016 license. For the Fedora package, we're fixing this here: > > https://src.fedoraproject.org/rpms/rust-regex-syntax/blob/rawhide/f/regex- > syntax-fix-metadata.diff > > So when building with vendored crates, you will need to add > "Unicode-DFS-2016" to the license tag manually. OK, will fix the license tag. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2308448 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202308448%23c17 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
