https://bugzilla.redhat.com/show_bug.cgi?id=2292549 --- Comment #18 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #17) > Thanks, looks good to me now! > > > # Remove dev dependencies for criterion, we wont run benchmarks > > sed -i '/^\[dev-dependencies.criterion\]/{N;N;d}' Cargo.toml > > Technically this isn't needed if you flip the check bcond to "off", but it > doesn't hurt to keep it. I intended to keep trying to enable tests every update or file bugs, and we don't want to package criterion right now :-) Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2292549 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202292549%23c18 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
