Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: udev https://bugzilla.redhat.com/show_bug.cgi?id=226510 limb@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |limb@xxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From limb@xxxxxxxxxxxx 2008-01-29 09:53 EST ------- rpmlint on srpm: udev.src: W: strange-permission start_udev 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. Not a problem. rpmlint on rpms: udev.i386: E: script-without-shebang /lib/udev/rule_generator.functions This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. Should be fixed. udev.i386: W: symlink-should-be-relative /usr/bin/udevtest /sbin/udevadm Absolute symlinks are problematic eg. when working with chroot environments. udev.i386: W: symlink-should-be-relative /usr/sbin/udevmonitor /sbin/udevadm Absolute symlinks are problematic eg. when working with chroot environments. udev.i386: W: symlink-should-be-relative /usr/bin/udevinfo /sbin/udevadm Absolute symlinks are problematic eg. when working with chroot environments. Not a problem. udev.i386: W: non-conffile-in-etc /etc/modprobe.d/floppy-pnp A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. udev.i386: W: conffile-without-noreplace-flag /etc/udev/makedev.d/50-udev.nodes A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/05-udev-early.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/40-alsa.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/40-redhat.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/50-udev-default.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/60-cdrom_id.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/60-persistent-input.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/60-persistent-storage-tape.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/60-persistent-storage.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/61-persistent-storage-edd.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/64-device-mapper.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/64-md-raid.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/75-cd-aliases-generator.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/75-persistent-net-generator.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/80-drivers.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/95-pam-console.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here udev.i386: W: conffile-without-noreplace-flag /etc/udev/rules.d/95-udev-late.rules A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here These should be OK, provided there is a place to create persistent rules. udev.i386: W: service-default-enabled /etc/rc.d/init.d/udev-post The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service. Fine. udev.i386: E: unknown-lsb-keyword # Requires: $local_fs udev.i386: E: missing-mandatory-lsb-keyword Provides in /etc/rc.d/init.d/udev-post The package contains an init script that does not contain one of the LSB comment block convention keywords that are mandatory. udev.i386: E: missing-mandatory-lsb-keyword Description in /etc/rc.d/init.d/udev-post The package contains an init script that does not contain one of the LSB comment block convention keywords that are mandatory. udev.i386: E: missing-mandatory-lsb-keyword Short-Description in /etc/rc.d/init.d/udev-post The package contains an init script that does not contain one of the LSB comment block convention keywords that are mandatory. Should be fixed. udev.i386: E: no-status-entry /etc/rc.d/init.d/udev-post In your init script (/etc/rc.d/init.d/your_file), you don't have a 'status' entry, which is necessary for good functionality. udev.i386: W: no-reload-entry /etc/rc.d/init.d/udev-post In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload' entry, which is necessary for good functionality. Should be fixed. udev.i386: E: subsys-not-used /etc/rc.d/init.d/udev-post While your daemon is running, you have to put a lock file in /var/lock/subsys/. To see an example, look at this directory on your machine and examine the corresponding init scripts. Should be fixed. udev.i386: W: incoherent-init-script-name udev-post The init script name should be the same as the package name in lower case, or one with 'd' appended if it invokes a process by that name. Probably not a problem. Has a .pc file, must Requires: pkgconfig. Other wise it looks good, no other blockers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review