https://bugzilla.redhat.com/show_bug.cgi?id=2276561 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #12 from Fabio Valentini <decathorpe@xxxxxxxxx> --- It looks like you manually yanked out all the stuff for building the application? But you missed some things, like """ %{cargo_license_summary} %{cargo_license} > LICENSE.dependencies """ There's an official rust2rpm.toml setting available that achieves "don't ship the executable" correctly: ```toml [package] cargo-install-bin = false ``` You also should *only* ever patch Cargo.toml with "rust2rpm -p". Changes to Cargo.toml (obviously) affect the generated .spec file, so they need to be applied *before* the spec file is generated. You can preserve the comment you added for the Cargo.toml patch like this: ```toml [package] cargo-toml-patch-comments = [ "Adjust versions of dependencies", ] You can also persist your patches with rust2rpm.toml settings like these: ```toml [[package.extra-patches]] number = 2 file = "rust-onenote_parser-updates.patch" comments = [ "Upstream bump of dependencies - merged but not yet released", "Modified to remove Cargo.toml changes since it gets reformatted and drop one change not yet present in Fedora:", "https://github.com/msiemens/onenote.rs/pull/9";, ] [[package.extra-patches]] number = 3 file = "https://github.com/msiemens/onenote.rs/pull/13.patch"; comments = [ "Apply Cisco-Talos patch as this is really only needed for clamav", ] ``` I'll attach a complete rust2rpm.toml file with all these settings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2276561 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276561%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
