https://bugzilla.redhat.com/show_bug.cgi?id=2305071 Nikola Forró <nforro@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Nikola Forró <nforro@xxxxxxxxxx> --- Thanks for packaging this! A few notes: > Source: %{url}/archive/%{version}/array-api-strict-%{version}.tar.gz I would suggest using %{pypi_source array_api_strict} here instead (and %autosetup -n array_api_strict-%{version} in %prep). > BuildRequires: python3-numpy This is not needed, numpy is detected by %pyproject_buildrequires. > %global _description %{expand: > array_api_strict is a strict, minimal implementation of the Python array API. > The purpose of array-api-strict is to provide an implementation of the array > API for consuming libraries to test against so they can be completely sure > their usage of the array API is portable.} I think it would make sense to include also the subsequent paragraph from the upstream README, to let users know this package is intended to be used by test suites. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2305071 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305071%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
