https://bugzilla.redhat.com/show_bug.cgi?id=2309684 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #3 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > Source0: %{name}-%{version}.tar.gz This should be a downloadable URL. Since the project is hosted on GitHub, you can use: > URL: https://github.com/sctech-tr/betterfetch > Source0: %{URL}/archive/v%{version}/%{name}-%{version}.tar.gz https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > %files > /usr/bin/betterfetch > /usr/bin/betterfetchrc > /etc/betterfetchrc > /etc/betterfetch-version Don't hardcode these paths. Replace /usr/bin with the %{_bindir} macro and /etc/ with the %{_sysconfdir} macro. This should be done in both the %files and %install sections. https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#macros_installation Also, please include the license text. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2309684 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202309684%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
