https://bugzilla.redhat.com/show_bug.cgi?id=2311827 --- Comment #2 from Jeremy Cline <jeremy@xxxxxxxxxx> --- It looks pretty good, there's just a few small things: It looks like the autorelease and autochangelog macros are expanded in the linked specfile, I imagine that was done by Copr. I recommend copying the Specfile and SRPM you prepare locally via ssh to `cjp256@xxxxxxxxxxxxxxxx` (it should accept keys you've configured on accounts.fedoraproject.org). Put it in the `public_html` folder and it'll be browsable at https://cjp256.fedorapeople.org/. The other thing is the `Provides` for the old package name is unversioned, which I think means the package is obsoleting itself. You want to do `Provides: azure-nvme-utils = %{version}-%{release}`. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2311827 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202311827%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
