https://bugzilla.redhat.com/show_bug.cgi?id=2307815 --- Comment #9 from Neil Hanlon <neil@xxxxxxxx> --- Thanks for the review! > > make %{?_smp_mflags} > %make_build made this change locally but forgot to push up > > cp %{_bindir}/shp2pgsql %{buildroot}%{_bindir}/shp2pgsql > Hmmm? This copies /usr/bin/shp2pgsql under %buildroot! great catch, I'm not really sure why that's there.. > > pushd %{buildroot}%{_datadir}/%{name}/ > > ln -s ../../../%{_sysconfdir}/%{name}/config.xml config.xml > > popd > > That pushd/popd is unnecessary. Just do > ln -s ../../../%{_sysconfdir}/%{name}/config.xml %{buildroot}%{_datadir}/%{name}/config.xml > or even better > ln -s --relative %{buildroot}%{_sysconfdir}/%{name}/config.xml %{buildroot}%{_datadir}/%{name}/ noted! thanks. > > %defattr(-,root,root,-) > Not needed. ack > %autorelease and %autochangelog? yeah, i probably should use these to make my life easier > The spec file looks reasonable, even if a bit dated. But I'm confused about the provenance of shp2pgsql. agreed, removed -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2307815 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202307815%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
