https://bugzilla.redhat.com/show_bug.cgi?id=2248952 Simone Caronni <negativo17@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #3 from Simone Caronni <negativo17@xxxxxxxxx> --- Hi Ali, Tom is correct in the above comments, please fix the patch to make the shared object name to have the same version, there's no point in making those different. The header part in the file list, should either be: %{_includedir}/* or: %{_includedir}/advisor-annotate.h %{_includedir}/ittnotify-zca.h %{_includedir}/ittnotify.h %{_includedir}/jitprofiling.h %{_includedir}/libittnotify.h %dir %{_includedir}/legacy %{_includedir}/legacy/ittnotify.h I see the binaries are no longer included, very good! Please fix the headers file list with one of the above before committing, otherwise pacakge approved! Thanks, --Simone -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2248952 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202248952%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
