https://bugzilla.redhat.com/show_bug.cgi?id=2248911 Simone Caronni <negativo17@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #6 from Simone Caronni <negativo17@xxxxxxxxx> --- Hi Ali, there are no releases for the project, so the correct syntax for the snapshot should be as follows: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots TL;DR: Remove the "with_snapshot" conditional and use this: Version: 0.0^%{gitdate}git%{shortcommit} These are up to you if you want: Shorten the %shortcommit to 7 characters: %global shortcommit %(c=%{commit}; echo ${c:0:7}) Move the test.c content into a single file that you check in with the SPEC file, I think it makes the SPEC file more readable. Otherwise, with the changes you added based on Trix comments, the package is fine. ** Please change the version before committing **, otherwise approved! Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2248911 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202248911%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
