[Bug 2292549] Review Request: rust-relm4 - Idiomatic GUI library inspired by Elm and based on gtk4-rs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2292549



--- Comment #10 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> ---
I misremembered. It does need rust-relm4-icons, but it builds a custom build in
the tests that needs an icons.toml.

So I've tried a few things.

1) The tests want criterion. Criterion wants a super specific version of
tempfile. Instead of dealing with that mess, I just remove criterion in %prep:

# Remove dev dependencies for criterion, we wont run benchmarks
sed -i '/^\[dev-dependencies.criterion\]/{N;N;d}' Cargo.toml

2) I've very frailly copied the system icons.toml in %check and fixed it up for
absolute paths so it is valid. The system one uses relative paths.

# Install icons.toml from rust-relm4-icons for tests
cp -pav /usr/share/cargo/registry/relm4-icons-*/icons.toml .
# Hack patch the path
sed -i
's@icons/fluentui-system-icons@/usr/share/cargo/registry/relm4-icons-0.8.3/icons/fluentui-system-icons@'
icons.toml

3) This gets us further in the tests, but fails with the following in Rawhide:

error[E0433]: failed to resolve: use of undeclared crate or module
`relm4_components`
 --> examples/state_management.rs:5:5
  |
5 | use relm4_components::open_dialog::{
  |     ^^^^^^^^^^^^^^^^ use of undeclared crate or module `relm4_components`

error[E0433]: failed to resolve: use of undeclared crate or module
`relm4_components`
 --> examples/state_management.rs:8:5
  |
8 | use relm4_components::save_dialog::{
  |     ^^^^^^^^^^^^^^^^ use of undeclared crate or module `relm4_components`

error[E0425]: cannot find value `TAG_OUTLINE_ADD` in module `icon_names`
  --> examples/state_management.rs:98:48
   |
98 |                     set_icon_name: icon_names::TAG_OUTLINE_ADD,
   |                                                ^^^^^^^^^^^^^^^ not found
in `icon_names`

Some errors have detailed explanations: E0425, E0433.
For more information about an error, try `rustc --explain E0425`.
error: could not compile `relm4` (example "state_management") due to 3 previous
errors

Okay, so we need relm4_components. However, rust-relm4-components needs
rust-relm4 so when trying to build rust-relm4-components first:

Problem 1: nothing provides requested (crate(relm4) >= 0.8.0 with crate(relm4)
< 0.9.0~)
Problem 2: nothing provides requested (crate(relm4/macros) >= 0.8.0 with
crate(relm4/macros) < 0.9.0~)

And oddly, also failed with a different error in F40:

error[E0425]: cannot find value `MINUS` in module `icon_names`
  --> examples/icons.rs:37:48
   |
37 |                     set_icon_name: icon_names::MINUS,
   |                                                ^^^^^ not found in
`icon_names`

For more information about this error, try `rustc --explain E0425`.
error: could not compile `relm4` (example "icons") due to 1 previous error

I've uploaded this current situation:

Spec URL: https://jsteffan.fedorapeople.org/envision/rust-relm4.spec
SRPM URL:
https://jsteffan.fedorapeople.org/envision/rust-relm4-0.8.1-1.fc40/rust-relm4-0.8.1-1.fc40.src.rpm

However, after documenting what is going on it seems the examples are what is
failing to build. Should/can we just turn those off?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2292549

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202292549%23c10

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux