https://bugzilla.redhat.com/show_bug.cgi?id=2303543 --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #3) > Looks very good. A few things that need tweaking perhaps: Thanks for the review! > Issues: > ======= > - Package must not depend on deprecated() packages. > Note: python3-pytest7 is deprecated, you must not depend on it. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/deprecating-packages/ > ^ > This must be a false positive, the pacakge does not explicitly depend on > pytest7 Agreed. > - Does the python3-bidsschematools sub-package need the MIT license tag > added to it? Definitely. Thanks for catching that. > - A couple of the directories are perhaps unowned (see below). Yes, I guess I need to explicitly own /usr/share/doc/python3-bidsschematools and /usr/share/doc/bids-schema. /usr/lib/python3.13/site-packages and /usr/lib/python3.13 are clearly false positives. > - Upstream has made new releases :( Will update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2303543 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202303543%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
