https://bugzilla.redhat.com/show_bug.cgi?id=2283539 --- Comment #5 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Looking very good. A few things to look at: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib64/mpich/lib/paraview/paraview/plugins/meshio/__pycache__/paraview- meshio-plugin.cpython-313.opt-1.pyc See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ^ This is fine. - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ^ False positive. - Where is README-test-files.md? - The GitHub repo, and so the Source, seems to already include the tests mesh files---is there a reason we're using a different archive/SOURCE for these instead? - Do the paraview packages also need to be split into -openmpi/-mpich sub-packages? - A few unowned directories need to be looked into. - python-meshio.spec:126: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/paraview ^ I think this is OK, since paraview is arched but the plugin files here are not. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MIT License", "MIT License". 197 files have unknown license. Detailed output of licensecheck in /home/asinha/dump/fedora-reviews/2283539-python- meshio/licensecheck.txt ^ Note that no license information is included upstream for the various test mesh files. [x]: License file installed when any subpackage combination is installed. [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/openmpi/lib/paraview/paraview/plugins/meshio/__pycache__, /usr/lib64/paraview/paraview/plugins/meshio/__pycache__, /usr/lib64/mpich/lib/paraview/paraview/plugins/meshio/__pycache__ ^ Do we need to own this directory? [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib64/openmpi/lib/paraview/paraview/plugins/meshio/__pycache__, /usr/lib64/mpich/lib/paraview/paraview/plugins/meshio/__pycache__, /usr/lib/python3.13, /usr/lib64/paraview/paraview/plugins/meshio/__pycache__ ^ Same as above. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/mpich(mpich), /usr/lib64/mpich/lib(mpich), /usr/lib64/mpich/lib/paraview(paraview- mpich), /usr/lib64/mpich/lib/paraview/paraview(paraview-mpich), /usr/lib64/mpich/lib/paraview/paraview/plugins(paraview-mpich), /usr/lib64/openmpi(openmpi), /usr/lib64/openmpi/lib(openmpi), /usr/lib64/openmpi/lib/paraview(paraview-openmpi), /usr/lib64/openmpi/lib/paraview/paraview(paraview-openmpi), /usr/lib64/openmpi/lib/paraview/paraview/plugins(paraview-openmpi), /usr/lib64/paraview(paraview), /usr/lib64/paraview/paraview(paraview), /usr/lib64/paraview/paraview/plugins(paraview) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 11543 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-meshio , paraview-meshio , python3-meshio+all [x]: Package functions as described. ^ All tests pass [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) ^ rpmautospec usage, ignore. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-meshio-5.3.5-5.fc42.noarch.rpm paraview-meshio-5.3.5-5.fc42.noarch.rpm python3-meshio+all-5.3.5-5.fc42.noarch.rpm python-meshio-5.3.5-5.fc42.src.rpm =================================================================================== rpmlint session starts =================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpapljzy96')] checks: 32, packages: 4 python-meshio.src: E: spelling-error ('Abaqus', '%description -l en_US Abaqus -> Abacus') python-meshio.src: E: spelling-error ('inp', '%description -l en_US inp -> nip, imp, in') python-meshio.src: E: spelling-error ('msh', '%description -l en_US msh -> ms, sh, mesh') python-meshio.src: E: spelling-error ('avs', '%description -l en_US avs -> abs, av, as') python-meshio.src: E: spelling-error ('cgns', '%description -l en_US cgns -> cans, cons, cosigns') python-meshio.src: E: spelling-error ('xml', '%description -l en_US xml -> XML, ml') python-meshio.src: E: spelling-error ('exo', '%description -l en_US exo -> exp, ex, exon') python-meshio.src: E: spelling-error ('mdpa', '%description -l en_US mdpa -> mudpack') python-meshio.src: E: spelling-error ('meshb', '%description -l en_US meshb -> mesh, mesh b') python-meshio.src: E: spelling-error ('bdf', '%description -l en_US bdf -> bf, PDF') python-meshio.src: E: spelling-error ('nas', '%description -l en_US nas -> ans, mas, as') python-meshio.src: E: spelling-error ('gz', '%description -l en_US gz -> g, z, gs') python-meshio.src: E: spelling-error ('precomputed', '%description -l en_US precomputed -> recomputed, p recomputed, computerized') python-meshio.src: E: spelling-error ('dato', '%description -l en_US dato -> date, data, dado') python-meshio.src: E: spelling-error ('stl', '%description -l en_US stl -> st, sol, std') python-meshio.src: E: spelling-error ('dat', '%description -l en_US dat -> DAT, tad, sat') python-meshio.src: E: spelling-error ('ele', '%description -l en_US ele -> lee, eel, eke') python-meshio.src: E: spelling-error ('svg', '%description -l en_US svg -> avg, sag, SVN') python-meshio.src: E: spelling-error ('ugrid', '%description -l en_US ugrid -> grid, u grid') python-meshio.src: E: spelling-error ('vtk', '%description -l en_US vtk -> VT') python-meshio.src: E: spelling-error ('vtu', '%description -l en_US vtu -> Stu, Btu, VT') python-meshio.src: E: spelling-error ('wkt', '%description -l en_US wkt -> wk, wt, kt') python-meshio.src: E: spelling-error ('xdmf', '%description -l en_US xdmf -> admix') python-meshio.src: E: spelling-error ('xmf', '%description -l en_US xmf -> emf, XML') python3-meshio+all.noarch: E: spelling-error ('Metapackage', 'Summary(en_US) Metapackage -> Meta package, Meta-package, Prepackage') python3-meshio+all.noarch: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage') python3-meshio.noarch: E: spelling-error ('inp', '%description -l en_US inp -> nip, imp, in') python3-meshio.noarch: E: spelling-error ('msh', '%description -l en_US msh -> ms, sh, mesh') python3-meshio.noarch: E: spelling-error ('avs', '%description -l en_US avs -> abs, av, as') python3-meshio.noarch: E: spelling-error ('xml', '%description -l en_US xml -> XML, ml') python3-meshio.noarch: E: spelling-error ('exo', '%description -l en_US exo -> exp, ex, exon') python3-meshio.noarch: E: spelling-error ('meshb', '%description -l en_US meshb -> mesh, mesh b') python3-meshio.noarch: E: spelling-error ('bdf', '%description -l en_US bdf -> bf, PDF') python3-meshio.noarch: E: spelling-error ('nas', '%description -l en_US nas -> ans, mas, as') python3-meshio.noarch: E: spelling-error ('gz', '%description -l en_US gz -> g, z, gs') python3-meshio.noarch: E: spelling-error ('precomputed', '%description -l en_US precomputed -> recomputed, p recomputed, computerized') python3-meshio.noarch: E: spelling-error ('dato', '%description -l en_US dato -> date, data, dado') python3-meshio.noarch: E: spelling-error ('dat', '%description -l en_US dat -> DAT, tad, sat') python3-meshio.noarch: E: spelling-error ('ele', '%description -l en_US ele -> lee, eel, eke') python3-meshio.noarch: E: spelling-error ('xmf', '%description -l en_US xmf -> emf, XML') paraview-meshio.noarch: W: only-non-binary-in-usr-lib paraview-meshio.noarch: E: noarch-with-lib64 paraview-meshio.noarch: W: no-documentation python3-meshio+all.noarch: W: no-documentation python-meshio.spec:126: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/paraview python-meshio.spec:127: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/paraview/paraview python-meshio.spec:128: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/paraview/paraview/plugins python-meshio.spec:129: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/paraview/paraview/plugins/%{pypi_name} python-meshio.spec:130: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %pycached %{_libdir}/paraview/paraview/plugins/%{pypi_name}/paraview-meshio-plugin.py python-meshio.spec:133: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/mpich python-meshio.spec:134: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/mpich/lib python-meshio.spec:135: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/mpich/lib/paraview python-meshio.spec:136: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/mpich/lib/paraview/paraview python-meshio.spec:137: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/mpich/lib/paraview/paraview/plugins python-meshio.spec:138: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/mpich/lib/paraview/paraview/plugins/%{pypi_name} python-meshio.spec:139: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %pycached %{_libdir}/mpich/lib/paraview/paraview/plugins/%{pypi_name}/paraview-meshio-plugin.py python-meshio.spec:142: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/openmpi python-meshio.spec:143: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/openmpi/lib python-meshio.spec:144: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/openmpi/lib/paraview python-meshio.spec:145: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/openmpi/lib/paraview/paraview python-meshio.spec:146: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/openmpi/lib/paraview/paraview/plugins python-meshio.spec:147: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %dir %{_libdir}/openmpi/lib/paraview/paraview/plugins/%{pypi_name} python-meshio.spec:148: W: libdir-macro-in-noarch-package paraview-%{pypi_name} %pycached %{_libdir}/openmpi/lib/paraview/paraview/plugins/%{pypi_name}/paraview-meshio-plugin.py python-meshio.spec: W: invalid-url Source1: meshio-test-files-5.3.5.tar.gz paraview-meshio.noarch: W: files-duplicate /usr/lib64/paraview/paraview/plugins/meshio/paraview-meshio-plugin.py /usr/lib64/mpich/lib/paraview/paraview/plugins/meshio/paraview-meshio-plugin.py:/usr/lib64/openmpi/lib/paraview/paraview/plugins/meshio/paraview-meshio-plugin.py ============================================ 4 packages and 0 specfiles checked; 41 errors, 24 warnings, 31 filtered, 41 badness; has taken 0.7 s ============================================ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 python3-meshio+all.noarch: E: spelling-error ('Metapackage', 'Summary(en_US) Metapackage -> Meta package, Meta-package, Prepackage') python3-meshio+all.noarch: E: spelling-error ('metapackage', '%description -l en_US metapackage -> meta package, meta-package, prepackage') python3-meshio.noarch: E: spelling-error ('inp', '%description -l en_US inp -> nip, imp, in') python3-meshio.noarch: E: spelling-error ('msh', '%description -l en_US msh -> ms, sh, mesh') python3-meshio.noarch: E: spelling-error ('avs', '%description -l en_US avs -> abs, av, as') python3-meshio.noarch: E: spelling-error ('xml', '%description -l en_US xml -> XML, ml') python3-meshio.noarch: E: spelling-error ('exo', '%description -l en_US exo -> exp, ex, exon') python3-meshio.noarch: E: spelling-error ('meshb', '%description -l en_US meshb -> mesh, mesh b') python3-meshio.noarch: E: spelling-error ('bdf', '%description -l en_US bdf -> bf, PDF') python3-meshio.noarch: E: spelling-error ('nas', '%description -l en_US nas -> ans, mas, as') python3-meshio.noarch: E: spelling-error ('gz', '%description -l en_US gz -> g, z, gs') python3-meshio.noarch: E: spelling-error ('precomputed', '%description -l en_US precomputed -> recomputed, p recomputed, computerized') python3-meshio.noarch: E: spelling-error ('dato', '%description -l en_US dato -> date, data, dado') python3-meshio.noarch: E: spelling-error ('dat', '%description -l en_US dat -> DAT, tad, sat') python3-meshio.noarch: E: spelling-error ('ele', '%description -l en_US ele -> lee, eel, eke') python3-meshio.noarch: E: spelling-error ('xmf', '%description -l en_US xmf -> emf, XML') paraview-meshio.noarch: W: only-non-binary-in-usr-lib paraview-meshio.noarch: E: noarch-with-lib64 python3-meshio+all.noarch: W: no-documentation paraview-meshio.noarch: W: no-documentation paraview-meshio.noarch: W: files-duplicate /usr/lib64/paraview/paraview/plugins/meshio/paraview-meshio-plugin.py /usr/lib64/mpich/lib/paraview/paraview/plugins/meshio/paraview-meshio-plugin.py:/usr/lib64/openmpi/lib/paraview/paraview/plugins/meshio/paraview-meshio-plugin.py 3 packages and 0 specfiles checked; 17 errors, 4 warnings, 27 filtered, 17 badness; has taken 0.3 s Source checksums ---------------- https://github.com/nschloe/meshio/archive/v5.3.5/meshio-5.3.5.tar.gz : CHECKSUM(SHA256) this package : 9e05d217857138d8f731803366c67acea2cfd67b0dd5aebe0281f1fb13ba57e5 CHECKSUM(SHA256) upstream package : 9e05d217857138d8f731803366c67acea2cfd67b0dd5aebe0281f1fb13ba57e5 Requires -------- python3-meshio (rpmlib, GLIBC filtered): (paraview-meshio if paraview) /usr/bin/python3 python(abi) python3.13dist(numpy) python3.13dist(rich) paraview-meshio (rpmlib, GLIBC filtered): paraview python3-meshio python3-meshio+all (rpmlib, GLIBC filtered): python(abi) python3-meshio python3.13dist(h5py) python3.13dist(netcdf4) Provides -------- python3-meshio: python-meshio python3-meshio python3.13-meshio python3.13dist(meshio) python3dist(meshio) paraview-meshio: paraview-meshio python3-meshio+all: python-meshio+all python3-meshio+all python3.13-meshio+all python3.13dist(meshio[all]) python3dist(meshio[all]) Diff spec file in url and in SRPM --------------------------------- --- /home/asinha/dump/fedora-reviews/2283539-python-meshio/srpm/python-meshio.spec 2024-09-11 11:40:43.911174180 +0100 +++ /home/asinha/dump/fedora-reviews/2283539-python-meshio/srpm-unpacked/python-meshio.spec 2024-07-03 01:00:00.000000000 +0100 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.6.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 5; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global pypi_name meshio @@ -140,3 +150,18 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Wed Jul 03 2024 Sandro <devel@xxxxxxxxxxxxx> - 5.3.5-5 +- Fix Requires + +* Tue May 28 2024 Sandro <devel@xxxxxxxxxxxxx> - 5.3.5-4 +- Add ParaView plugin + +* Mon May 27 2024 Sandro <devel@xxxxxxxxxxxxx> - 5.3.5-3 +- Add test files + +* Mon May 27 2024 Sandro <devel@xxxxxxxxxxxxx> - 5.3.5-2 +- Add man pages + +* Mon May 27 2024 Sandro <devel@xxxxxxxxxxxxx> - 5.3.5-1 +- Initial package +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2283539 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: C/C++, R, Ocaml, SugarActivity, PHP, Perl, Java, fonts, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2283539 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283539%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
