[Bug 2269411] Review Request: bpfman - EBPF Program Manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2269411

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(decathorpe@gmail. |
                   |com)                        |



--- Comment #22 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
> %cargo_license_summary
> %cargo_license

Not sure why you copied these macros to the %prep scriptlet? They do nothing
there, and they're duplicated in %build later (where they belong).
I'm not sure that this is the cause of the problem, but it's not helping.

> License:        Apache-2.0

This is also not correct, it needs to be adapted according to the output of the
%cargo_license_summary macro.

If SourceLicense and License were actually identical, you'd only need to
specify the latter.


> Spec URL: https://dmellado.fedorapeople.org/bpfman/bpfman.spec
> SRPM URL: https://dmellado.fedorapeople.org/bpfman/bpfman-0.5.1-vendor.tar.xz

Looks like you copied the vendor tarball instead of the SRPM here?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2269411

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202269411%23c22

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux