[Bug 2310622] Review request: imsprog - I2C, SPI, MicroWire and DataFlash EEPROM chip programmer for CH341a devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2310622



--- Comment #25 from Mikhail Medvedev <e-ink-reader@xxxxxxxxx> ---
 Peter Lemenkov, hello!

What was done:

1. The line “Group: Devel” was changed to “Group: Applications/Engineering”
(line 15)

2. The translation commands update has been moved to the build section

3. Added “desktop-file-utils” to “BuildRequires” to check desktop files (line
26)

4. Added desktop files check to the “%check” section (line 169)

5. Added “libappstream-glib” to “BuildRequires” to check metadata files (line
26)

6. Added  metadata files check to the “%check” section (line 171)

7. The imsprog has been rebuilded



What I forgot:
"Are you sure these metainfo-files are not necessary?"
- Yes, you can keep them.

Which I couldn't do:
"* %license field needs some love. "
If I add the "%license GPL-2.0-or-later AND GPL-3.0-or-later AND LGPL-2.1-only"
command to the "%files" section, I get a message that the files don't exist. I
don't understand how to do it correctly yet and I ask for your help.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2310622

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202310622%23c25

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux