https://bugzilla.redhat.com/show_bug.cgi?id=2305930 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |177841 (FE-NEEDSPONSOR) --- Comment #21 from Cristian Le <fedora@xxxxxxxxx> --- You did great Michael, don't worry too much about it :). Package reviews are not exams, and it's more like we all learn from one another. A few final points: - you have an extra "}" in the %description at the end - the quotes in %pyproject_save_files do not do anything and since you are supposed to pass python modules I think it's better to drop them since those would never have spaces in them - consider using `autospec` macros [1,2]. Basically you change the `Release` to `%autorelease` and instead of writing the entries manually, put a `%autochangelog`. One thing to be aware is that all your commits will appear as entries in the changelog, so be mindful of what you write there ;). See [2] for more on how you control - please add a `-l` to the %pyproject_save_files. This makes sure that there is at least one file marked as %license retrieved through PEP639 (which will soon be finalized so not all backends have implemented it yet). If it fails to build, you may need to add `%license LICENSE` to %files and correct the `pyproject.toml` for a future release I can give you a few more tips for the project as an upstream developer. Just ping me (LecrisUT on Github) in an issue and I'll write you there. As for this package, I would mark it approved, but you still need sponsorship so it doesn't help much to do so. I will post your bug on fedora-devel matrix channel to see if anyone is free to go through your process. [1]: https://docs.pagure.org/fedora-infra.rpmautospec/autorelease.html [2]: https://docs.pagure.org/fedora-infra.rpmautospec/autochangelog.html Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2305930 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305930%23c21 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
