https://bugzilla.redhat.com/show_bug.cgi?id=2310677 Tyler Fanelli <tfanelli@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |NOTABUG Status|NEW |CLOSED Last Closed| |2024-09-09 18:24:41 --- Comment #3 from Tyler Fanelli <tfanelli@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #1) > Welcome to this (apparently?) initiation ritual for Rust packagers! > This is the fourth or fifth (?) time it was submitted for review :D > > - criterion is a benchmarking library. > - benchmarks are neither compiled nor run during package builds. > - you can just patch out the dev-dependency with "rust2rpm -p". > > Unless you are packaging a tool that uses criterion (or other benchmarking > libraries) at runtime, there's no reason to have this in Fedora. And with that, I'll close this issue as not needed. Thanks for clearing this up :) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2310677 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202310677%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
