https://bugzilla.redhat.com/show_bug.cgi?id=2050552 Dan Čermák <dan.cermak@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(dan.cermak@cgc-in | |struments.com) | --- Comment #10 from Dan Čermák <dan.cermak@xxxxxxxxxxxxxxxxxxx> --- (In reply to Steve Traylen from comment #7) > Spec URL: > https://cern.ch/straylen/rpms/python-elasticsearch7/python-elasticsearch7. > spec > SRPM URL: > https://cern.ch/straylen/rpms/python-elasticsearch7/python-elasticsearch7-7. > 17.9-1.el9.src.rpm > > Switches to the %py3_build and _install macros - thanks. > > As for doing elasticsearch8 this would be a seperate review. elasticsearch7 > and elasticsearch8 are distinct pypi names and > can co-exist on EPEL9 for instance. Makes sense! Looks good now, thanks for the fixes. I'd suggest that you switch the license identifier to SPDX though (`Apache-2.0`) instead of the Callway identifier. Also upstream published two new minor releases in the mean time, feel free to add them now too or upgrade it later. Package is approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2050552 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202050552%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue