https://bugzilla.redhat.com/show_bug.cgi?id=2305930 --- Comment #14 from Michael Berry <trismegustis@xxxxxxxxx> --- (In reply to Elliott Sales de Andrade from comment #11) > > %global _description %{expand:...} > > This variable is also only used in place (for `%description`), so you might > as well inline it there as well. > > > %global pypi_name btrfs_backup_ng > > This variable is only used in one place (for `%py_provides`), so you might > as well inline it there too, removing its definition, but see also below. > > > %py_provides %{pypi_name} > > Requires: btrfs-progs > > These are both part of your `%description` and don't actually do anything > where they are. Checking the built package: > > $ rpm -q --provides -p ./btrfs-backup-ng-0.6.3-9.fc42.noarch.rpm > btrfs-backup-ng = 0.6.3-9.fc42 > python3.13dist(btrfs-backup-ng) = 0.6.3 > python3dist(btrfs-backup-ng) = 0.6.3 > > $ rpm -q --requires -p ./btrfs-backup-ng-0.6.3-9.fc42.noarch.rpm > /usr/bin/python3 > python(abi) = 3.13 > python3.13dist(rich) > rpmlib(CompressedFileNames) <= 3.0.4-1 > rpmlib(FileDigests) <= 4.6.0-1 > rpmlib(PartialHardlinkSets) <= 4.0.4-1 > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > rpmlib(PayloadIsZstd) <= 5.4.18-1 > > So the `Provides` are already automatically detected and correct, but there > are no `Requires` for `btrfs-progs`. You should move the `Requires` before > the `%description`, and drop the `%py_provides` call. > > I would also remove the remaining comments; they're instructions for you, > and you've already completed them. > > I also cannot sponsor you. Thank you for your review and comments, I see know where I had obviously messed things up and not manually checking the rpm for provides and requires was a serious mistake. I also was missing an essential require of python3-rich. I made the changes you suggested and made sure to check things out better this time. Your help is greatly appreciated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2305930 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305930%23c14 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
